chore(cfc): remove orphaned snapshots and group negative lit tests - #1908
Open
volsa wants to merge 2 commits into
Open
chore(cfc): remove orphaned snapshots and group negative lit tests#1908volsa wants to merge 2 commits into
volsa wants to merge 2 commits into
Conversation
volsa
changed the title
Build Artifacts🐧 Linux
From workflow run 🪟 Windows
From workflow run |
volsa
marked this pull request as ready for review
September 8, 2026 17:07
Problem: ten snapshots under tests/integration/snapshots belong to CFC tests that were deleted with the plc_xml crate, so nothing reads them. Solution: delete them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Problem: the CFC lit tests that assert a diagnostic are scattered across the feature folders, next to the runtime tests. Solution: gather them under tests/lit/cfc/validation so location and diagnostic checks live in one place. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
volsa
force-pushed
the
vosa/PRG-4757-1
branch
from
September 10, 2026 16:24
04de5cd to
0a0e41c
Compare
|
1 finding in 1m 29s for $0.03 between
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Ten
tests__integration__cfc__ir__*snapshots survived the removal of the plc_xml integration tests in #1807 and no test reads them anymore. The CFC lit tests that assert diagnostics are spread acrossblocks/andvariables/.Solution: Delete the orphaned snapshots and group the negative lit tests under
tests/lit/cfc/validation, where the follow-up location diagnostics tests will live.Refs: PRG-4757