feat(cfc): emit diagram locations in debug info - #1910
Merged
Merged
Conversation
Build Artifacts🐧 Linux
From workflow run 🪟 Windows
From workflow run |
volsa
changed the title
volsa
commented
Sep 8, 2026
| Illustrated: | ||
| ``` | ||
| +-------- myAdd ---------+ | ||
| a1 ------o-| IN1 myAdd |-o------> b1 (2) |
Member
Author
There was a problem hiding this comment.
should not have a return pin name, same as PR 2. Maybe we need to tackle this in a follow up PR?
volsa
marked this pull request as ready for review
September 8, 2026 18:52
volsa
force-pushed
the
vosa/PRG-4757-3
branch
from
September 10, 2026 16:24
1fec564 to
5eb0956
Compare
|
2 findings in 10m 39s for $0.42 between
|
ghaith
reviewed
Sep 14, 2026
ghaith
left a comment
ghaith
left a comment
Collaborator
There was a problem hiding this comment.
OK for me, since the clanker has comments i'll wait for your signal to approve
Problem: the debug line of a diagram statement lands in the same DWARF file as the declaration, so line 1 is ambiguous between declaration line 1 and execution order 0. Solution: emit a second debug file <file>.cfc.<diagram> and scope diagram statements to it through a lexical block, with the execution order plus one as the line, since DWARF reserves line 0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Problem: the checks read as a chain of anonymous metadata numbers. Solution: order them from source file to instruction, name each group, and open with the diagram under test. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
volsa
force-pushed
the
vosa/PRG-4757-3
branch
from
September 14, 2026 09:29
5eb0956 to
dd6c2ed
Compare
ghaith
approved these changes
Sep 14, 2026
|
0 findings in 6m 59s for $0.25 between |
An error occurred while trying to automatically change base from
vosa/PRG-4757-2
to
vosa/PRG-4757-1
September 14, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When debugging a CFC POU, the IDE has to map a stop or a breakpoint to one of its two editors: the text area with the declaration, addressed by line, or the node graph, addressed by execution order. The debug info attributes both to the same source file
<file>.cfc, somain.cfc:1may mean declaration line 1 or execution order 0 and the IDE cannot tell which.Solution: Attribute node graph statements to their own source file
<file>.cfc.<diagram>in the debug info, at line execution order plus one since DWARF reserves line 0, while the declaration stays in<file>.cfc. The file name alone now tells the IDE which editor a location belongs to, mirroring the diagnostics format of the previous PR.Refs: PRG-4757