Skip to content

fix(resolver): resolve call arguments once (1.0.x) #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volsa merged 1 commit into from
Oct 6, 2026
Merged

fix(resolver): resolve call arguments once (1.0.x) #1961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/resolver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,8 @@ impl TypeAnnotator<'_> {
))
}

/// annotates the arguments of a call, the arguments must be resolved already
pub fn annotate_arguments(&mut self, operator: &AstNode, arguments_node: &AstNode, ctx: &VisitorContext) {
self.visit_statement(ctx, arguments_node);
let arguments = flatten_expression_list(arguments_node);

let pou_name = {
Expand Down
20 changes: 20 additions & 0 deletions tests/lit/single/functions/deeply_nested_calls.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// RUN: %COMPILE %s && %RUN | %CHECK %s
// Deeply nested calls compile in time linear to their depth

FUNCTION increment : DINT
VAR_INPUT
value : DINT;
END_VAR

increment := value + 1;
END_FUNCTION

FUNCTION main
VAR
x : DINT := 0;
END_VAR

x := increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(increment(x))))))))))))))))))))))))))))));
printf('%d$N', x); // CHECK: 30

END_FUNCTION
Loading