Repository navigation
Unrestrict SWANN downloads - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpinned
_earlyas the only version of SWANN files to ingest, as UA seems to sometimes skip versions on missing sets or daily uploads and go straight to_provisionalor_stableversions.snowtool downloadnow iterates through each possible qualifier when attempting a SWANN download as we won't know which one is going to be available on a requested date.This won't create any foreseeable issues with version mismatching/data inconsistency for a number of reasons:
snowtool download retryuses thediagnostics.missing_datesas a source of truth for missing datasets. So only sets missing in SWANN'scogpath will be re-attemptedsnowtool download [date|retry]is completely separate from the actual ingesting of the datasets and only handles the fetching of the raw data. This degree of separation prevents sets from being automatically imported in and overwritten