Clarify PSBT witness test comment to reflect actual Taproot support boundaries - #5
Draft
PandaKitten96 with Copilot wants to merge 2 commits into
Draft
Clarify PSBT witness test comment to reflect actual Taproot support boundaries#5PandaKitten96 with Copilot wants to merge 2 commits into
PandaKitten96 with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Update comment to clarify P2TR support limitations
Clarify PSBT witness test comment to reflect actual Taproot support boundaries
Jun 22, 2026
PandaKitten96
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PSBT test comment implied
P2TRwas generally unsupported, which is inaccurate given existing key-path support in PSBT handling and tx building. This updates the test annotation to document the real current limitation: unsupported witness paths areP2WSHandP2TRscript-path.Comment accuracy update (PSBT witness path)
rust/tw_tests/tests/chains/bitcoin/bitcoin_sign/psbt.rsto avoid conflating allP2TRwith unsupported behavior.P2WPKHwitness UTXO) and explicitly called out unsupported cases.Behavioral scope documented
P2WSH) in this PSBT flow.