Skip to content

Clarify PSBT witness test comment to reflect actual Taproot support boundaries - #5

Draft
PandaKitten96 with Copilot wants to merge 2 commits into
masterfrom
copilot/update-p2tr-comment
Draft

Clarify PSBT witness test comment to reflect actual Taproot support boundaries#5
PandaKitten96 with Copilot wants to merge 2 commits into
masterfrom
copilot/update-p2tr-comment

Conversation

Copilot AI commented Jun 22, 2026

Copy link
Copy Markdown

The PSBT test comment implied P2TR was generally unsupported, which is inaccurate given existing key-path support in PSBT handling and tx building. This updates the test annotation to document the real current limitation: unsupported witness paths are P2WSH and P2TR script-path.

  • Comment accuracy update (PSBT witness path)

    • Reworded the inline comment in rust/tw_tests/tests/chains/bitcoin/bitcoin_sign/psbt.rs to avoid conflating all P2TR with unsupported behavior.
    • Kept scope specific to the tested path (P2WPKH witness UTXO) and explicitly called out unsupported cases.
  • Behavioral scope documented

    • Clarifies that the limitation is not Taproot key-path itself, but Taproot script-path (and P2WSH) in this PSBT flow.
// This test path uses a supported witness UTXO script type (P2WPKH).
// Please note that `P2WSH` and `P2TR` script-path witness inputs are not supported yet.

Copilot AI changed the title [WIP] Update comment to clarify P2TR support limitations Clarify PSBT witness test comment to reflect actual Taproot support boundaries Jun 22, 2026
Copilot AI requested a review from PandaKitten96 June 22, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants