Repository navigation
test(web): derive jump-box cases from the demo repo's numbers - #36
Merged
Merged
Conversation
…chain x3 hard-coded #3 as an issue-only number; another suite has since opened PRs #3 and #4 on forge-v2-demo, so #3 is both and the spec failed. It now reads the repo's issue and PR numbers from Platform and checks each case that exists: both (the chooser, with each link), issue only, PR only, and a number with neither. The seed script notes that issue and PR numbers are independent and shared on purpose. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #32.
v2-explore.spec.tsx3 hard-coded#3as an issue-only number onforge-v2-demo. Another suite has since opened PRs #3 and #4 on that repo, so#3now exists as both an issue and a PR, and the "straight to the issue" assertion failed.On moutai today the repo has issues 1–3 and PRs 1–4.
Changes
v2-auth.spec.tsdoes, and checks every case that currently exists:seed-v2-fixture.mjsgets a comment only. Issue and PR numbers are independent by design (forge-v2 §6), the build: make the Rust workspace buildable and pin the Platform SDK #1 pair is intentional, and other suites add PRs here. The script creates issues 1–3 and PRs 1–2 with fixed numbers and cannot collide with itself.Test plan
E2E_DEVNET=moutai E2E_PORT=4323 pnpm exec playwright test v2-explore.spec.ts: 5/5 passed--repeat-each 3: 15/15 passedpnpm typecheck && pnpm lint🤖 Generated with Claude Code