Fix AscendancyStart deallocation and Abyssal Lich node allocation#1934
Open
Peechey wants to merge 1 commit into
Open
Conversation
fix abyssal lich reverting to lich when allocating any ascendancy node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This PR prevent users from deallocating the AscendancyStart node, bricking any further allocation until they change ascendancies, and stops Abyssal Lich converting to Lich when allocating any Abyssal Lich ascendancy node.
If we want to keep the tooltip with the name of the Ascendancy on hover, I've got an alternate solution for that, but the current solution matches pob1 behavior.
Sorry about the art, the recording software butchers it.
Before screenshot:
After screenshot: