More image formats...#433
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
it may be worth looking into making a script that could manually convert one of these 4 formats into the other 3 so people who submit don't have to do it manually |
|
we use avif due to it having the best network performance, and we dont care about anything other then latest firefox/chrome; both of which support avif. also the inclusion of JPEG XL just wastes space since its not supported by either browser. |
|
ideally the AVIF conversion can be handled by a github action one day |
You are wrong, jpex XL is supported by every majour browser and even adobe, do any research before closing stuff that wasnt even meant for you too look at? |
This is true today but may not be true for long. Firefox isn't against support and neither is Chrome; the only issue is whether a memory safe decoder will be made, which is the main issue. See
This actually isn't true, either. JPEG-XL is only supported by Safari at the moment: https://caniuse.com/jpegxl. |
clearly you are not correct with that when i just updated both of my installs of firefox and chrome to latest this week, and neither would render the .jxl image type despite recognizing what it was. |
|
As for the idea that it's a "waste of space," GitHub doesn't have space requirements so this point is N/A, at least in my opinion. |
still have to download allat :bfdi: |
doesnt matter? its only 2MB in total, all of your points for closing this are completely invalid at this point |
when was the key point the made up the first half of the closing sentence debunked? |
|
If you're talking about end user browsers, then no, that's not true. If properly setup with If you're talking about Git, then that somewhat makes sense, but at the end of the day anything added to this repository will make it have more to download. |
|
what, i edit and it reposted the hell |
git is still only 2-5MB of data which isnt big at all, and if you read the code it uses picture to add support, obviouslly depends on compression, but even then git and the browser are smart enough to optimize the transfer |
yeah im talking about the later, only two mb though thats crazy low for what i thought it was.... |
|
the best solution would probably be the picture element with all formats + a script to automatically convert the ext thumbnails and make a commit to the repo to add them |
it already uses picture.... |
|
well yea i mean keeping that |
|
Could you reopen this? |
i asked in dms and he said no |
|
Oh, alright. I just thought I'd ask because it feels a bit shitty to take a bit of code from someone's commit and do the common PenguinMod thing of forgetting to add authorship information to the commit. |
if they take it then i literally wasted my time |
|
i wasnt gonna do that, also i wasnt sure about reopening before but its probably fine now |
|
I am marking this as draft so people do not close this without further discussion, I will work on a action like jeremy suggested (while adding a script so its easier to develop and test); if you have a problem please just post it instead of closing my pull request :< |
JeremyGamer13
added
the
non-extension
4 participants
AVIF isnt really that well supported in the global landscape.. which was the original reason for this pull request.
But.. this adds JPEG XL, WEBP and PNG files too for all the raster images, JPEG XL is under less support but is smaller than AVIF, WEBP is bigger than AVIF but smaller than PNG, and PNG is the most supported, this lets the browser optimize based on support and size with support being PNG, WEBP, AVIF then JPEG XL.. and size being the reverse
related: 3f9621c
as in this also saves bandwidth while improving compatibility where possible
FYI: I don't know svletekit so if there is a better way to do that SVG check PLEASE tell me!!