chore(warnings): sweep mechanical Rust warnings and drop blanket #[allow(unused_imports)] by TheHypnoo · Pull Request #6639 · PerryTS/perry

TheHypnoo · 2026-07-18T20:30:25Z

Summary

Mechanical Rust warning cleanup across the workspace — no behavioral change. This is the first, zero-risk slice of a larger warning-elimination effort (the workspace currently emits ~1338 warnings on a clean cargo check); it clears the fully mechanical categories and the blanket import-suppression debt.

Two commits:

cargo fix mechanical sweep — removes unused imports, unnecessary unsafe blocks, unused mut/braces, and unused assignments. cargo fix handles most of these; unused_unsafe is applied by a span-driven pass because rustc emits that lint without a machine-applicable suggestion (removing an unnecessary unsafe block is safe by definition — if it were needed, it would not be flagged).
Drop 444 blanket #[allow(unused_imports)] and prune — these attributes papered over duplicated import preambles in mechanically-split files. Removing them and re-running cargo fix prunes the now-visible unused imports. The warning count does not rise afterward, confirming the suppressed imports were all genuinely removable. Two documented, intentional allows remain.

Impact

Workspace warning count: 1338 → 281 (this branch covers the mechanical + import-suppression share).
#[allow(unused_imports)]: 444 → 2 (both remaining are documented and deliberate).

Validation

cargo check --workspace (excluding cross-host UI crates): 0 errors.
cargo fmt --all --check: clean.
cargo check --workspace --tests: no new errors from this change (the one pre-existing failure — a stale CompileOptions field reference in perry-codegen/tests/perry_builtin_name_collision.rs — is unrelated and already present on main).

Notes

No version bump or CHANGELOG entry — left for the maintainer to fold in at merge, per the repo's contributor convention.
Remaining 281 warnings need per-item judgment (dead_code, clashing extern declarations, unreachable patterns, etc.) and are handled in follow-up PRs.

Summary by CodeRabbit

Bug Fixes
- Improved native-call handling when optional parameters are omitted, supplying appropriate default values for more reliable execution.
Refactor
- Streamlined internal module wiring and removed redundant imports across compilation, runtime, standard-library, and analysis components.
- Consolidated selected compilation and runtime helpers without changing supported APIs or normal behavior.
Maintenance
- Reduced warning suppressions and clarified internal dependencies, improving build cleanliness and long-term maintainability.

coderabbitai · 2026-07-18T20:30:46Z

📝 Walkthrough

Walkthrough

This PR removes unused imports and warning suppressions, narrows internal re-exports, simplifies several local bindings, and adds focused helpers for method-name registration, global-property lowering, and omitted native-parameter padding.

Changes

Repository-wide Rust cleanup

Layer / File(s)	Summary
WASM emitter cleanup `crates/perry-codegen-wasm/src/emit/*`	Removes an unused local binding and replaces an unused-import suppression with an explicit retained import.
Codegen cleanup and helper extraction `crates/perry-codegen/src/codegen/`, `crates/perry-codegen/src/expr/`, `crates/perry-codegen/src/lower_call/`, `crates/perry-codegen/src/type_analysis`	Narrowed imports and re-exports across codegen modules; adds method-name registration, global-property lowering, and omitted native-parameter padding helpers.
HIR cleanup `crates/perry-hir/src/destructuring/`, `crates/perry-hir/src/lower`, `crates/perry-hir/src/lower_decl/`, `crates/perry-hir/src/lower_types`	Removes unused imports and reduces internal re-export surfaces without changing the described lowering behavior.
Runtime cleanup `crates/perry-runtime/src/*`	Narrowed imports, wildcard scopes, internal re-exports, and unused bindings across runtime subsystems.
Standard-library and CLI cleanup `crates/perry-stdlib/src/`, `crates/perry/src/commands/compile/cjs_wrap/`, `crates/perry-ext-http/src/lib.rs`	Removes unused imports and warning suppressions, narrows sibling imports, and preserves existing dispatch and test logic.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

PerryTS/perry#5423: Similar mechanical cleanup of imports and internal re-exports in HIR lowering modules.

Suggested labels: ready

Suggested reviewers: proggeramlug

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is informative, but it does not follow the template sections for Changes, Related issue, Test plan, or Checklist.	Add the missing template sections: a Changes bullet list, Related issue (or n/a), a checkbox-style Test plan, and the checklist items.
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: a mechanical warning cleanup and removal of blanket unused-import allowances.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/warnings-mechanical-sweep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Drop 445 blanket #[allow(unused_imports)] across 86 host-buildable crates, prune the exposed dead imports with `cargo fix --all-targets`, and delete four dead bindings cargo fix could only underscore. Parent imports used solely by #[cfg(test)] sibling modules via `super::` are restored #[cfg(test)]-gated.

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

crates/perry-codegen/src/expr/property_get/globalget.rs (1)

83-133: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Consolidate duplicated lowering logic for built-in statics and native modules.

The manual lowering block for "hasOwn" (lines 112-133) is identical to the logic performed by lower_global_builtin_static_value(ctx, "Object", property). You can safely remove this block and simply add "hasOwn" to the matches! list for Object above (lines 83-102).

Similarly, consider reusing lower_global_builtin_static_value (if its implementation is generic) or extracting a shared helper for Error, ArrayBuffer, Uint8Array, SubtleCrypto, and Math to eliminate the extensive duplicated boilerplate. The same applies to the native module property lookups for console and process, which share identical emission logic.

♻️ Proposed fix to consolidate `"hasOwn"`

@@ -97,7 +97,8 @@
             | "getOwnPropertyNames"
             | "getOwnPropertySymbols"
             | "getOwnPropertyDescriptors"
-            | "defineProperties"
+            | "defineProperties"
+            | "hasOwn"
     ) {
         return Ok(lower_global_builtin_static_value(ctx, "Object", property));
     }
-    // `#3527`: `Object.hasOwn` read as a VALUE (not a direct call) —
-    // e.g. iconv-lite's merge-exports does
-    // `var hasOwn = typeof Object.hasOwn === "undefined" ? … :
-    // Object.hasOwn` then `hasOwn(obj, key)`. The ternary defeats
-    // the const-alias call-fold, so the value must be a real
-    // callable. Mirror the `Error.captureStackTrace` shape above:
-    // resolve the reified `Object` constructor closure and read the
-    // `hasOwn` static (installed by `install_builtin_constructor_statics`)
-    // off it, instead of falling through to the `0.0` sentinel.
-    if property == "hasOwn" {
-        let object_idx = ctx.strings.intern("Object");
-        let object_bytes_global = format!("@{}", ctx.strings.entry(object_idx).bytes_global);
-        let object_len = "Object".len().to_string();
-        let object_ctor = ctx.block().call(
-            DOUBLE,
-            "js_get_global_this_builtin_value",
-            &[(PTR, &object_bytes_global), (I64, &object_len)],
-        );
-        let key_idx = ctx.strings.intern(property);
-        let key_handle_global = format!("@{}", ctx.strings.entry(key_idx).handle_global);
-        let blk = ctx.block();
-        let ctor_handle = unbox_to_i64(blk, &object_ctor);
-        let key_box = blk.load(DOUBLE, &key_handle_global);
-        let key_bits = blk.bitcast_double_to_i64(&key_box);
-        let key_raw = blk.and(I64, &key_bits, POINTER_MASK_I64);
-        return Ok(blk.call(
-            DOUBLE,
-            "js_object_get_field_by_name_f64",
-            &[(I64, &ctor_handle), (I64, &key_raw)],
-        ));
-    }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/perry-codegen/src/expr/property_get/globalget.rs` around lines 83 -
133, Consolidate the Object.hasOwn lowering by adding "hasOwn" to the existing
Object static-property matches! list and removing the manual block that resolves
the constructor and field. Reuse lower_global_builtin_static_value for this
path, preserving the existing behavior while eliminating duplicated emission
logic.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@crates/perry-codegen/src/expr/property_get/globalget.rs`:
- Around line 83-133: Consolidate the Object.hasOwn lowering by adding "hasOwn"
to the existing Object static-property matches! list and removing the manual
block that resolves the constructor and field. Reuse
lower_global_builtin_static_value for this path, preserving the existing
behavior while eliminating duplicated emission logic.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 84b76afc-8e5c-489f-9c0f-595ef665f3e6

📥 Commits

Reviewing files that changed from the base of the PR and between 0adf0d2 and 0b1835a.

📒 Files selected for processing (294)

crates/perry-codegen-wasm/src/emit/compile.rs
crates/perry-codegen-wasm/src/emit/mod.rs
crates/perry-codegen-wasm/src/emit/runtime_imports.rs
crates/perry-codegen-wasm/src/emit/ui_method_map.rs
crates/perry-codegen/src/codegen/boxed_locals.rs
crates/perry-codegen/src/codegen/closure.rs
crates/perry-codegen/src/codegen/closure_collect.rs
crates/perry-codegen/src/codegen/func_registry.rs
crates/perry-codegen/src/codegen/function.rs
crates/perry-codegen/src/codegen/i64_spec.rs
crates/perry-codegen/src/codegen/method_registry.rs
crates/perry-codegen/src/codegen/mod.rs
crates/perry-codegen/src/codegen/module_globals_emit.rs
crates/perry-codegen/src/collectors/mod.rs
crates/perry-codegen/src/expr/array_methods.rs
crates/perry-codegen/src/expr/array_push.rs
crates/perry-codegen/src/expr/arrays_finds.rs
crates/perry-codegen/src/expr/bigint_set.rs
crates/perry-codegen/src/expr/binary.rs
crates/perry-codegen/src/expr/buffer_access.rs
crates/perry-codegen/src/expr/call_spread.rs
crates/perry-codegen/src/expr/calls.rs
crates/perry-codegen/src/expr/calls/crypto_hash.rs
crates/perry-codegen/src/expr/calls/crypto_kdf.rs
crates/perry-codegen/src/expr/calls/crypto_keys.rs
crates/perry-codegen/src/expr/calls/crypto_misc.rs
crates/perry-codegen/src/expr/calls/fs.rs
crates/perry-codegen/src/expr/calls/helpers.rs
crates/perry-codegen/src/expr/child_proc.rs
crates/perry-codegen/src/expr/closure.rs
crates/perry-codegen/src/expr/compare.rs
crates/perry-codegen/src/expr/conditional.rs
crates/perry-codegen/src/expr/dispatch.rs
crates/perry-codegen/src/expr/dyn_extern_i18n.rs
crates/perry-codegen/src/expr/env_clones.rs
crates/perry-codegen/src/expr/fs_await.rs
crates/perry-codegen/src/expr/index_get.rs
crates/perry-codegen/src/expr/index_set.rs
crates/perry-codegen/src/expr/instance_misc1.rs
crates/perry-codegen/src/expr/js_runtime.rs
crates/perry-codegen/src/expr/literals_vars.rs
crates/perry-codegen/src/expr/logical_collections.rs
crates/perry-codegen/src/expr/math_simple.rs
crates/perry-codegen/src/expr/misc_methods.rs
crates/perry-codegen/src/expr/mod.rs
crates/perry-codegen/src/expr/new_dynamic.rs
crates/perry-codegen/src/expr/objects_arrays_lit.rs
crates/perry-codegen/src/expr/os_uri_dates.rs
crates/perry-codegen/src/expr/property_get.rs
crates/perry-codegen/src/expr/property_get/generic_dispatch.rs
crates/perry-codegen/src/expr/property_get/globalget.rs
crates/perry-codegen/src/expr/property_get/helpers.rs
crates/perry-codegen/src/expr/property_set.rs
crates/perry-codegen/src/expr/proxy_reflect.rs
crates/perry-codegen/src/expr/record_value.rs
crates/perry-codegen/src/expr/shadow_slot.rs
crates/perry-codegen/src/expr/static_field_meta.rs
crates/perry-codegen/src/expr/static_method.rs
crates/perry-codegen/src/expr/string_regex_proc.rs
crates/perry-codegen/src/expr/super_method.rs
crates/perry-codegen/src/expr/this_super_call.rs
crates/perry-codegen/src/expr/unary.rs
crates/perry-codegen/src/expr/url_main.rs
crates/perry-codegen/src/lower_call/mod.rs
crates/perry-codegen/src/lower_call/new.rs
crates/perry-codegen/src/lower_call/omitted_native_params.rs
crates/perry-codegen/src/lower_call/property_get.rs
crates/perry-codegen/src/lower_call/property_get/dynamic_dispatch.rs
crates/perry-codegen/src/lower_call/property_get/fetch_chain.rs
crates/perry-codegen/src/lower_call/property_get/helpers.rs
crates/perry-codegen/src/lower_call/property_get/map_set.rs
crates/perry-codegen/src/lower_call/property_get/number_string.rs
crates/perry-codegen/src/lower_call/property_get/promise_chain.rs
crates/perry-codegen/src/lower_call/property_get/static_dispatch.rs
crates/perry-codegen/src/native_value/verify.rs
crates/perry-codegen/src/native_value/verify/abi.rs
crates/perry-codegen/src/native_value/verify/layout.rs
crates/perry-codegen/src/native_value/verify/raw_f64.rs
crates/perry-codegen/src/runtime_decls/stdlib_ffi/data_stores.rs
crates/perry-codegen/src/runtime_decls/stdlib_ffi/language_core.rs
crates/perry-codegen/src/runtime_decls/stdlib_ffi/net_http.rs
crates/perry-codegen/src/runtime_decls/stdlib_ffi/streams_events.rs
crates/perry-codegen/src/runtime_decls/stdlib_ffi/third_party.rs
crates/perry-codegen/src/runtime_decls/stdlib_ffi/utilities.rs
crates/perry-codegen/src/runtime_decls/stdlib_ffi/web.rs
crates/perry-codegen/src/type_analysis.rs
crates/perry-codegen/src/type_analysis/numeric.rs
crates/perry-codegen/src/type_analysis/pod.rs
crates/perry-codegen/src/type_analysis/predicates.rs
crates/perry-codegen/src/type_analysis/refine.rs
crates/perry-codegen/src/type_analysis/strings.rs
crates/perry-ext-http/src/lib.rs
crates/perry-hir/src/destructuring/mod.rs
crates/perry-hir/src/destructuring/var_decl/alias_tracking.rs
crates/perry-hir/src/destructuring/var_decl/binding_guards.rs
crates/perry-hir/src/destructuring/var_decl/native_fetch.rs
crates/perry-hir/src/destructuring/var_decl/native_new.rs
crates/perry-hir/src/destructuring/var_decl/type_infer.rs
crates/perry-hir/src/lower/closure_analysis.rs
crates/perry-hir/src/lower/context.rs
crates/perry-hir/src/lower/decorators.rs
crates/perry-hir/src/lower/expr_call/intrinsics.rs
crates/perry-hir/src/lower/expr_call/intrinsics/apply_call.rs
crates/perry-hir/src/lower/expr_call/intrinsics/bare_builtins.rs
crates/perry-hir/src/lower/expr_call/intrinsics/eval_strict.rs
crates/perry-hir/src/lower/expr_call/intrinsics/namespace_static.rs
crates/perry-hir/src/lower/expr_call/intrinsics/native_arena.rs
crates/perry-hir/src/lower/expr_call/intrinsics/precompile_wasm.rs
crates/perry-hir/src/lower/expr_call/intrinsics/require.rs
crates/perry-hir/src/lower/expr_member.rs
crates/perry-hir/src/lower/expr_member/native_dispatch.rs
crates/perry-hir/src/lower/expr_member/private_guard.rs
crates/perry-hir/src/lower/expr_member/process_literals.rs
crates/perry-hir/src/lower/expr_member/process_props.rs
crates/perry-hir/src/lower/expr_member/stdlib_guard.rs
crates/perry-hir/src/lower/expr_new.rs
crates/perry-hir/src/lower/expr_new/helpers.rs
crates/perry-hir/src/lower/expr_new/member.rs
crates/perry-hir/src/lower/expr_new/non_ident.rs
crates/perry-hir/src/lower/expr_object.rs
crates/perry-hir/src/lower/lower_expr.rs
crates/perry-hir/src/lower/lower_expr/arm_bin.rs
crates/perry-hir/src/lower/lower_expr/arm_class.rs
crates/perry-hir/src/lower/lower_expr/arm_ident.rs
crates/perry-hir/src/lower/lower_expr/arm_optchain.rs
crates/perry-hir/src/lower/lower_expr/arm_unary.rs
crates/perry-hir/src/lower/lower_expr/assignment.rs
crates/perry-hir/src/lower/lower_expr/helpers.rs
crates/perry-hir/src/lower/lower_expr/reactive_text.rs
crates/perry-hir/src/lower/misc.rs
crates/perry-hir/src/lower/module_decl.rs
crates/perry-hir/src/lower/module_decl/namespace.rs
crates/perry-hir/src/lower/module_decl/native_default_import.rs
crates/perry-hir/src/lower/pre_scan.rs
crates/perry-hir/src/lower/shared_mutable_capture.rs
crates/perry-hir/src/lower/stmt.rs
crates/perry-hir/src/lower/template.rs
crates/perry-hir/src/lower/widget_decl.rs
crates/perry-hir/src/lower/widget_decl/reactive_animate.rs
crates/perry-hir/src/lower_decl/block.rs
crates/perry-hir/src/lower_decl/mod.rs
crates/perry-hir/src/lower_types.rs
crates/perry-hir/src/lower_types/extract.rs
crates/perry-runtime/src/array/from_concat.rs
crates/perry-runtime/src/buffer/header.rs
crates/perry-runtime/src/buffer/mod.rs
crates/perry-runtime/src/buffer/view.rs
crates/perry-runtime/src/child_process/builder.rs
crates/perry-runtime/src/child_process/emitter.rs
crates/perry-runtime/src/child_process/exec.rs
crates/perry-runtime/src/child_process/mod.rs
crates/perry-runtime/src/child_process/options.rs
crates/perry-runtime/src/child_process/output.rs
crates/perry-runtime/src/child_process/registry.rs
crates/perry-runtime/src/child_process/signals.rs
crates/perry-runtime/src/child_process/value_util.rs
crates/perry-runtime/src/closure/dispatch/bound.rs
crates/perry-runtime/src/closure/dispatch/calln.rs
crates/perry-runtime/src/closure/dispatch/errors.rs
crates/perry-runtime/src/closure/dispatch/validate.rs
crates/perry-runtime/src/closure/dispatch/value_call.rs
crates/perry-runtime/src/dgram.rs
crates/perry-runtime/src/dgram/ffi.rs
crates/perry-runtime/src/dgram/listeners.rs
crates/perry-runtime/src/dgram/net.rs
crates/perry-runtime/src/dgram/ops.rs
crates/perry-runtime/src/dgram/thunks.rs
crates/perry-runtime/src/dns.rs
crates/perry-runtime/src/dns/ffi.rs
crates/perry-runtime/src/dns/records.rs
crates/perry-runtime/src/dns/resolve_build.rs
crates/perry-runtime/src/fs/dir_glob_watch.rs
crates/perry-runtime/src/fs/dir_glob_watch/glob.rs
crates/perry-runtime/src/fs/dir_glob_watch/opendir.rs
crates/perry-runtime/src/fs/dir_glob_watch/watch.rs
crates/perry-runtime/src/fs/errors.rs
crates/perry-runtime/src/fs/fd_sync_ops.rs
crates/perry-runtime/src/fs/mod.rs
crates/perry-runtime/src/gc/copying.rs
crates/perry-runtime/src/gc/cycle.rs
crates/perry-runtime/src/gc/mod.rs
crates/perry-runtime/src/gc/tests/triggers.rs
crates/perry-runtime/src/intl.rs
crates/perry-runtime/src/intl/date_collator.rs
crates/perry-runtime/src/intl/list_relative_plural.rs
crates/perry-runtime/src/intl/number_format.rs
crates/perry-runtime/src/intl/number_format_options.rs
crates/perry-runtime/src/intl/segmenter.rs
crates/perry-runtime/src/json/mod.rs
crates/perry-runtime/src/json/replacer.rs
crates/perry-runtime/src/json/stringify.rs
crates/perry-runtime/src/json/stringify_scalars.rs
crates/perry-runtime/src/json/stringify_tojson_probe.rs
crates/perry-runtime/src/map.rs
crates/perry-runtime/src/node_stream_compose_live.rs
crates/perry-runtime/src/node_stream_constructors.rs
crates/perry-runtime/src/node_stream_constructors/builders.rs
crates/perry-runtime/src/node_stream_constructors/introspection.rs
crates/perry-runtime/src/node_stream_constructors/pipeline.rs
crates/perry-runtime/src/node_stream_constructors/web_adapter.rs
crates/perry-runtime/src/node_stream_dispatch.rs
crates/perry-runtime/src/node_stream_duplex_methods.rs
crates/perry-runtime/src/node_stream_iter_helpers.rs
crates/perry-runtime/src/node_stream_json.rs
crates/perry-runtime/src/node_stream_keys.rs
crates/perry-runtime/src/node_stream_pipeline.rs
crates/perry-runtime/src/node_stream_readwrite.rs
crates/perry-runtime/src/object/class_meta_registry.rs
crates/perry-runtime/src/object/class_registry.rs
crates/perry-runtime/src/object/class_registry/class_meta.rs
crates/perry-runtime/src/object/class_registry/construct.rs
crates/perry-runtime/src/object/class_registry/dispatch.rs
crates/perry-runtime/src/object/class_registry/gc_roots.rs
crates/perry-runtime/src/object/class_registry/parent_static.rs
crates/perry-runtime/src/object/class_registry/prototype_methods.rs
crates/perry-runtime/src/object/class_registry/prototype_objects.rs
crates/perry-runtime/src/object/class_registry/registration.rs
crates/perry-runtime/src/object/class_registry/state.rs
crates/perry-runtime/src/object/descriptor_state.rs
crates/perry-runtime/src/object/field_get_set.rs
crates/perry-runtime/src/object/global_this.rs
crates/perry-runtime/src/object/global_this/bigint_promise.rs
crates/perry-runtime/src/object/global_this/builtin_thunks.rs
crates/perry-runtime/src/object/mod.rs
crates/perry-runtime/src/object/native_call_method/collection_methods.rs
crates/perry-runtime/src/object/native_call_method/common_methods.rs
crates/perry-runtime/src/object/native_call_method/disposal.rs
crates/perry-runtime/src/object/native_call_method/handle_methods.rs
crates/perry-runtime/src/object/native_call_method/object_proto.rs
crates/perry-runtime/src/object/native_call_method/primitive_methods.rs
crates/perry-runtime/src/object/native_call_method/proto_dispatch.rs
crates/perry-runtime/src/object/native_call_method/string_methods.rs
crates/perry-runtime/src/object/native_call_method/typed_array.rs
crates/perry-runtime/src/object/native_module.rs
crates/perry-runtime/src/object/native_module/callable_export_check.rs
crates/perry-runtime/src/object/native_module/callable_exports.rs
crates/perry-runtime/src/object/native_module/constants.rs
crates/perry-runtime/src/object/native_module/module_keys.rs
crates/perry-runtime/src/object/native_module/namespace_builders.rs
crates/perry-runtime/src/object/native_module/web_locks.rs
crates/perry-runtime/src/object/object_ops.rs
crates/perry-runtime/src/object/object_ops/define_properties.rs
crates/perry-runtime/src/object/this_binding.rs
crates/perry-runtime/src/object/to_string_tag.rs
crates/perry-runtime/src/process.rs
crates/perry-runtime/src/process/env_misc.rs
crates/perry-runtime/src/process/finalization.rs
crates/perry-runtime/src/process/node_module.rs
crates/perry-runtime/src/process/permission.rs
crates/perry-runtime/src/process/report.rs
crates/perry-runtime/src/promise/then.rs
crates/perry-runtime/src/proxy/reflect_misc.rs
crates/perry-runtime/src/regex/exec.rs
crates/perry-runtime/src/regex/match_string.rs
crates/perry-runtime/src/symbol.rs
crates/perry-runtime/src/symbol/constructors.rs
crates/perry-runtime/src/symbol/gc_roots.rs
crates/perry-runtime/src/symbol/get.rs
crates/perry-runtime/src/symbol/iterator.rs
crates/perry-runtime/src/symbol/properties.rs
crates/perry-runtime/src/temporal/plain_date_time.rs
crates/perry-runtime/src/temporal/plain_time.rs
crates/perry-runtime/src/temporal/plain_year_month.rs
crates/perry-runtime/src/typedarray/access.rs
crates/perry-runtime/src/typedarray/construct.rs
crates/perry-runtime/src/typedarray/iterate.rs
crates/perry-runtime/src/typedarray/mod.rs
crates/perry-runtime/src/typedarray/slice_ops.rs
crates/perry-runtime/src/typedarray/transform.rs
crates/perry-runtime/src/url/node_compat.rs
crates/perry-stdlib/src/common/dispatch.rs
crates/perry-stdlib/src/common/dispatch/fastify_net_zlib.rs
crates/perry-stdlib/src/common/dispatch/init.rs
crates/perry-stdlib/src/common/dispatch/sqlite.rs
crates/perry-stdlib/src/crypto.rs
crates/perry-stdlib/src/events.rs
crates/perry-stdlib/src/events/events_on.rs
crates/perry-stdlib/src/events/module_helpers.rs
crates/perry-stdlib/src/events/once_helpers.rs
crates/perry-stdlib/src/framework/multipart.rs
crates/perry-stdlib/src/sqlite.rs
crates/perry-stdlib/src/sqlite/backup.rs
crates/perry-stdlib/src/sqlite/better.rs
crates/perry-stdlib/src/sqlite/bind.rs
crates/perry-stdlib/src/sqlite/connection.rs
crates/perry-stdlib/src/sqlite/dispatch.rs
crates/perry-stdlib/src/sqlite/node_db.rs
crates/perry-stdlib/src/sqlite/node_stmt_session.rs
crates/perry-stdlib/src/sqlite/node_tag_store.rs
crates/perry-stdlib/src/sqlite/options.rs
crates/perry-stdlib/src/webcrypto.rs
crates/perry/src/commands/compile/cjs_wrap/detect.rs
crates/perry/src/commands/compile/cjs_wrap/extract_requires.rs
crates/perry/src/commands/compile/cjs_wrap/hoist_classes.rs

💤 Files with no reviewable changes (91)

crates/perry-codegen-wasm/src/emit/runtime_imports.rs
crates/perry-codegen/src/codegen/i64_spec.rs
crates/perry-codegen/src/codegen/boxed_locals.rs
crates/perry-runtime/src/fs/errors.rs
crates/perry-runtime/src/object/native_call_method/common_methods.rs
crates/perry-codegen-wasm/src/emit/ui_method_map.rs
crates/perry-stdlib/src/common/dispatch/sqlite.rs
crates/perry-codegen/src/codegen/closure.rs
crates/perry-runtime/src/closure/dispatch/validate.rs
crates/perry-runtime/src/typedarray/slice_ops.rs
crates/perry-runtime/src/buffer/header.rs
crates/perry-hir/src/lower/expr_member/stdlib_guard.rs
crates/perry-runtime/src/node_stream_duplex_methods.rs
crates/perry-runtime/src/typedarray/transform.rs
crates/perry-runtime/src/object/native_module/web_locks.rs
crates/perry-runtime/src/closure/dispatch/bound.rs
crates/perry-runtime/src/closure/dispatch/calln.rs
crates/perry-runtime/src/object/native_call_method/handle_methods.rs
crates/perry-runtime/src/object/class_registry/prototype_methods.rs
crates/perry-runtime/src/object/native_call_method/string_methods.rs
crates/perry-runtime/src/object/native_call_method/proto_dispatch.rs
crates/perry-stdlib/src/common/dispatch/fastify_net_zlib.rs
crates/perry-runtime/src/node_stream_compose_live.rs
crates/perry-runtime/src/closure/dispatch/errors.rs
crates/perry-hir/src/lower/expr_member/process_literals.rs
crates/perry-runtime/src/node_stream_json.rs
crates/perry-runtime/src/buffer/view.rs
crates/perry-runtime/src/typedarray/mod.rs
crates/perry-runtime/src/object/native_call_method/primitive_methods.rs
crates/perry/src/commands/compile/cjs_wrap/extract_requires.rs
crates/perry-codegen/src/codegen/func_registry.rs
crates/perry-runtime/src/object/native_call_method/object_proto.rs
crates/perry-runtime/src/process/env_misc.rs
crates/perry-runtime/src/node_stream_constructors.rs
crates/perry-runtime/src/object/class_registry/state.rs
crates/perry-runtime/src/object/native_call_method/collection_methods.rs
crates/perry-runtime/src/object/global_this/builtin_thunks.rs
crates/perry-runtime/src/regex/exec.rs
crates/perry-runtime/src/symbol/gc_roots.rs
crates/perry-stdlib/src/common/dispatch/init.rs
crates/perry-runtime/src/node_stream_keys.rs
crates/perry-runtime/src/object/class_registry/class_meta.rs
crates/perry-runtime/src/typedarray/iterate.rs
crates/perry-runtime/src/json/stringify_scalars.rs
crates/perry-hir/src/lower_decl/mod.rs
crates/perry-stdlib/src/common/dispatch.rs
crates/perry-runtime/src/object/class_registry/gc_roots.rs
crates/perry-runtime/src/object/native_call_method/typed_array.rs
crates/perry-runtime/src/fs/dir_glob_watch/watch.rs
crates/perry-runtime/src/json/stringify.rs
crates/perry-runtime/src/child_process/signals.rs
crates/perry-codegen-wasm/src/emit/mod.rs
crates/perry-hir/src/lower/lower_expr/assignment.rs
crates/perry-runtime/src/proxy/reflect_misc.rs
crates/perry-runtime/src/closure/dispatch/value_call.rs
crates/perry-runtime/src/process.rs
crates/perry-runtime/src/buffer/mod.rs
crates/perry-hir/src/lower/lower_expr/reactive_text.rs
crates/perry-runtime/src/object/class_meta_registry.rs
crates/perry/src/commands/compile/cjs_wrap/detect.rs
crates/perry-hir/src/lower/expr_member/native_dispatch.rs
crates/perry-runtime/src/process/permission.rs
crates/perry-runtime/src/object/global_this/bigint_promise.rs
crates/perry/src/commands/compile/cjs_wrap/hoist_classes.rs
crates/perry-runtime/src/process/report.rs
crates/perry-runtime/src/object/native_module/callable_export_check.rs
crates/perry-runtime/src/regex/match_string.rs
crates/perry-codegen-wasm/src/emit/compile.rs
crates/perry-runtime/src/object/native_call_method/disposal.rs
crates/perry-hir/src/lower/pre_scan.rs
crates/perry-hir/src/lower/lower_expr/arm_bin.rs
crates/perry-runtime/src/typedarray/construct.rs
crates/perry-runtime/src/map.rs
crates/perry-codegen/src/type_analysis/numeric.rs
crates/perry-runtime/src/promise/then.rs
crates/perry-hir/src/lower/expr_member.rs
crates/perry-hir/src/lower/widget_decl.rs
crates/perry-runtime/src/object/object_ops/define_properties.rs
crates/perry-runtime/src/symbol/iterator.rs
crates/perry-runtime/src/dgram/ffi.rs
crates/perry-runtime/src/object/to_string_tag.rs
crates/perry-runtime/src/fs/dir_glob_watch/opendir.rs
crates/perry-runtime/src/gc/tests/triggers.rs
crates/perry-ext-http/src/lib.rs
crates/perry-runtime/src/typedarray/access.rs
crates/perry-runtime/src/object/native_module/module_keys.rs
crates/perry-hir/src/lower/module_decl/native_default_import.rs
crates/perry-runtime/src/json/replacer.rs
crates/perry-runtime/src/process/finalization.rs
crates/perry-hir/src/lower/expr_call/intrinsics.rs
crates/perry-hir/src/lower/expr_new/non_ident.rs

TheHypnoo force-pushed the chore/warnings-mechanical-sweep branch 2 times, most recently from 0ef5601 to 902f045 Compare July 21, 2026 08:59

TheHypnoo force-pushed the chore/warnings-mechanical-sweep branch from 902f045 to 0b1835a Compare July 21, 2026 10:02

coderabbitai Bot reviewed Jul 21, 2026

View reviewed changes

proggeramlug merged commit c5b6100 into main Jul 21, 2026
27 checks passed

proggeramlug deleted the chore/warnings-mechanical-sweep branch July 21, 2026 11:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(warnings): sweep mechanical Rust warnings and drop blanket #[allow(unused_imports)]#6639

chore(warnings): sweep mechanical Rust warnings and drop blanket #[allow(unused_imports)]#6639
proggeramlug merged 1 commit into
mainfrom
chore/warnings-mechanical-sweep

TheHypnoo commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (2 warnings)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

TheHypnoo commented Jul 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Impact

Validation

Notes

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (2 warnings)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TheHypnoo commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading