Skip to content

fix(runtime): path and url default to win32 semantics on Windows #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 2 commits into from
Jul 20, 2026
Merged

fix(runtime): path and url default to win32 semantics on Windows #6663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c993f70
fix(runtime): path and url default to win32 semantics on Windows
Jul 19, 2026
5d69001
Merge branch 'main' into fix/win-path-url-defaults
proggeramlug Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions crates/perry-hir/src/lower/expr_call/nested_namespace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,47 @@ pub(super) fn dispatch_path_subnamespace(
method: &str,
args: Vec<Expr>,
) -> Result<Expr, Vec<Expr>> {
// On Windows-host builds the default `js_path_*` runtime family resolves
// to win32 semantics (Node: `path === path.win32` on win32). The static
// posix rewrite below shares those symbols (`Expr::PathX`), so it would
// lose the explicit-posix pinning. Route `path.posix.<method>(...)`
// through the runtime by-name dispatcher instead — `nm_dispatch_path`'s
// `("path.posix", …)` arms call the pinned `js_path_posix_*` family. On
// non-Windows hosts the base family IS posix, so the static rewrite
// stays byte-identical there.
if sub == "posix" && cfg!(windows) {
const RUNTIME_DISPATCHED: &[&str] = &[
"join",
"dirname",
"basename",
"extname",
"isAbsolute",
"normalize",
"parse",
"format",
"toNamespacedPath",
"_makeLong",
"relative",
"resolve",
"matchesGlob",
];
if RUNTIME_DISPATCHED.contains(&method) {
// `path.posix.join()` with no args folds to "." like the static
// arm below (and like win32 join).
if method == "join" && args.is_empty() {
return Ok(Expr::String(".".to_string()));
}
return Ok(Expr::NativeMethodCall {
module: "path.posix".to_string(),
class_name: None,
object: None,
method: method.to_string(),
args,
});
}
return Err(args);
}

// path.<sub>.join(...)
if method == "join" {
if args.is_empty() {
Expand Down
54 changes: 31 additions & 23 deletions crates/perry-runtime/src/object/native_module_dispatch/dispatch_m_p.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,13 +373,13 @@ pub(crate) unsafe fn nm_dispatch_path(ctx: &NmCtx, module_name: &str, method_nam
result = if win32 {
crate::path::js_path_win32_resolve_join(result, segment)
} else {
crate::path::js_path_resolve_join(result, segment)
crate::path::js_path_posix_resolve_join(result, segment)
};
}
if win32 {
str_to_f64(crate::path::js_path_win32_resolve(result))
} else {
str_to_f64(crate::path::js_path_resolve(result))
str_to_f64(crate::path::js_path_posix_resolve(result))
}
};
let path_basename_value = |win32: bool| -> f64 {
Expand All @@ -392,20 +392,24 @@ pub(crate) unsafe fn nm_dispatch_path(ctx: &NmCtx, module_name: &str, method_nam
str_to_f64(crate::path::js_path_win32_basename_ext(path, ext))
}
} else if ext.is_null() {
str_to_f64(crate::path::js_path_basename(path))
str_to_f64(crate::path::js_path_posix_basename(path))
} else {
str_to_f64(crate::path::js_path_basename_ext(path, ext))
str_to_f64(crate::path::js_path_posix_basename_ext(path, ext))
}
};
match (module_name, method_name) {
// Default `path.*` — platform semantics (Node: `path === path.win32`
// on Windows). The direct `crate::path::js_path_*` calls below are
// themselves platform-dispatching; the closure-based arms select the
// family with `cfg!(windows)`.
("path", "dirname") => str_to_f64(crate::path::js_path_dirname(require_path_str_ptr(0))),
("path", "basename") => path_basename_value(false),
("path", "basename") => path_basename_value(cfg!(windows)),
("path", "extname") => str_to_f64(crate::path::js_path_extname(require_path_str_ptr(0))),
("path", "normalize") => {
str_to_f64(crate::path::js_path_normalize(require_path_str_ptr(0)))
}
("path", "resolve") => path_resolve_value(false),
("path", "join") => path_join_value(false),
("path", "resolve") => path_resolve_value(cfg!(windows)),
("path", "join") => path_join_value(cfg!(windows)),
("path", "relative") => str_to_f64(crate::path::js_path_relative(
require_path_str_ptr(0),
require_path_str_ptr(1),
Expand All @@ -430,9 +434,11 @@ pub(crate) unsafe fn nm_dispatch_path(ctx: &NmCtx, module_name: &str, method_nam
// (property reads) already worked, but method calls landed here with
// module_name "path.win32" / "path.posix" and no matching arm, so they
// returned undefined. win32 routes to the `js_path_win32_*` family;
// posix routes to the base `js_path_*` family (POSIX `/` semantics),
// mirroring how the static `path.win32.X()` / `path.posix.X()` forms
// lower in codegen.
// posix routes to the pinned `js_path_posix_*` family (the base
// `js_path_*` family is platform-dispatching, so it can no longer
// stand in for explicit posix). On Windows targets the static
// `path.posix.X()` forms also lower to these arms (see
// `dispatch_path_subnamespace` in perry-hir).
("path.win32", "dirname") => {
str_to_f64(crate::path::js_path_win32_dirname(require_path_str_ptr(0)))
}
Expand Down Expand Up @@ -465,34 +471,36 @@ pub(crate) unsafe fn nm_dispatch_path(ctx: &NmCtx, module_name: &str, method_nam
}
("path.win32", "format") => str_to_f64(crate::path::js_path_win32_format(arg(0))),
("path.posix", "dirname") => {
str_to_f64(crate::path::js_path_dirname(require_path_str_ptr(0)))
str_to_f64(crate::path::js_path_posix_dirname(require_path_str_ptr(0)))
}
("path.posix", "basename") => path_basename_value(false),
("path.posix", "extname") => {
str_to_f64(crate::path::js_path_extname(require_path_str_ptr(0)))
}
("path.posix", "normalize") => {
str_to_f64(crate::path::js_path_normalize(require_path_str_ptr(0)))
str_to_f64(crate::path::js_path_posix_extname(require_path_str_ptr(0)))
}
("path.posix", "normalize") => str_to_f64(crate::path::js_path_posix_normalize(
require_path_str_ptr(0),
)),
("path.posix", "resolve") => path_resolve_value(false),
("path.posix", "join") => path_join_value(false),
("path.posix", "relative") => str_to_f64(crate::path::js_path_relative(
("path.posix", "relative") => str_to_f64(crate::path::js_path_posix_relative(
require_path_str_ptr(0),
require_path_str_ptr(1),
)),
("path.posix", "toNamespacedPath") => crate::path::js_path_to_namespaced_path_value(arg(0)),
("path.posix", "_makeLong") => crate::path::js_path_to_namespaced_path_value(arg(0)),
("path.posix", "isAbsolute") => {
bool_to_f64(crate::path::js_path_is_absolute(require_path_str_ptr(0)))
("path.posix", "toNamespacedPath") => {
crate::path::js_path_posix_to_namespaced_path_value(arg(0))
}
("path.posix", "matchesGlob") => bool_to_f64(crate::path::js_path_matches_glob(
("path.posix", "_makeLong") => crate::path::js_path_posix_to_namespaced_path_value(arg(0)),
("path.posix", "isAbsolute") => bool_to_f64(crate::path::js_path_posix_is_absolute(
require_path_str_ptr(0),
)),
("path.posix", "matchesGlob") => bool_to_f64(crate::path::js_path_posix_matches_glob(
require_path_str_ptr(0),
require_path_str_ptr(1),
)),
("path.posix", "parse") => {
ptr_to_f64(crate::path::js_path_parse(require_path_str_ptr(0)) as *const u8)
ptr_to_f64(crate::path::js_path_posix_parse(require_path_str_ptr(0)) as *const u8)
}
("path.posix", "format") => str_to_f64(crate::path::js_path_format(arg(0))),
("path.posix", "format") => str_to_f64(crate::path::js_path_posix_format(arg(0))),

// ── util module ──
_ => f64::from_bits(JSValue::undefined().bits()),
Expand Down
Loading
Loading