Add eq_fixed option to BoundaryError#2264
Conversation
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | -3.44 % | 4.095e+03 | 3.954e+03 | -140.99 | 30.35 | 28.94 |
test_proximal_jac_w7x_with_eq_update | -0.58 % | 6.619e+03 | 6.580e+03 | -38.25 | 152.79 | 151.46 |
test_proximal_freeb_jac | -0.58 % | 1.342e+04 | 1.335e+04 | -77.54 | 79.34 | 79.13 |
test_proximal_freeb_jac_blocked | 0.03 % | 7.726e+03 | 7.728e+03 | 2.27 | 68.99 | 69.00 |
test_proximal_freeb_jac_batched | 0.11 % | 7.653e+03 | 7.661e+03 | 8.25 | 68.70 | 69.11 |
test_proximal_jac_ripple | 1.52 % | 3.536e+03 | 3.589e+03 | 53.74 | 52.56 | 52.14 |
test_proximal_jac_ripple_bounce1d | 0.36 % | 3.720e+03 | 3.733e+03 | 13.50 | 66.94 | 65.82 |
test_eq_solve | 0.10 % | 1.929e+03 | 1.931e+03 | 1.93 | 57.99 | 58.00 |For the memory plots, go to the summary of |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2264 +/- ##
==========================================
- Coverage 94.30% 94.30% -0.01%
==========================================
Files 101 101
Lines 28866 28901 +35
==========================================
+ Hits 27223 27255 +32
- Misses 1643 1646 +3
🚀 New features to boost your workflow:
|
YigitElma
left a comment
There was a problem hiding this comment.
You can also add a test like test_toroidal_flux to check all paths run fine.
|
I think the reason tests are failing is that constants["field"] is a SumMagneticField and it expects a list for the params. So, the parameter assignment needs a bit more care. For this objective, field can be something like [MixedCoilSet(), ToroidalMagneticField()]. |
…it test accordingly.
…Control/DESC into ia/BoundaryError-eq_fixed to sync with master
YigitElma
left a comment
There was a problem hiding this comment.
About the formatting and linting check, if you run the following, they will happen automatically everytime you commit something.
pip install pre-commit
pre-commit install
These and some other useful instructions can be found on the Contributing Guide.
YigitElma
left a comment
There was a problem hiding this comment.
Note to other devs: The failing test is related to jax-finufft version 1.2.0 and not caused by this PR. We should solve that problem separetaly or wait CI to run that test on a different python version (which doesn't install jax-finufft 1.2.0)
Co-authored-by: Yigit Gunsur Elmacioglu <102380275+YigitElma@users.noreply.github.com>
An option to remove the equilibrium as an optimizable DOF when computing BoundaryError is included.