Add Benchmarks regarding Coil Optimization - #2266
Merged
Merged
Conversation
…s is redundant benchmark
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2266 +/- ##
==========================================
- Coverage 94.31% 94.30% -0.01%
==========================================
Files 101 101
Lines 28932 28934 +2
==========================================
- Hits 27288 27287 -1
- Misses 1644 1647 +3
🚀 New features to boost your workflow:
|
lkadz
reviewed
Jul 16, 2026
This was referenced Jul 22, 2026
Open
ddudt
requested changes
Jul 23, 2026
Collaborator
Author
|
Default to no check for intersections, change the docstring for new default, add to the changelog. |
…lSet method, that is probably useful
lkadz
reviewed
Jul 24, 2026
IssraAli
previously approved these changes
Jul 24, 2026
ddudt
previously approved these changes
Jul 25, 2026
lkadz
previously approved these changes
Jul 28, 2026
ddudt
previously approved these changes
Jul 28, 2026
…s when new one is submitted
Collaborator
Author
|
Sorry for the last minute changes, I realized that memory benchmark script had a bug in the import and the benchmarks in general were taking too long on CI (the jacobian one was 4 seconds on my laptop CPU but 40 seconds on CI). I fixed the bug and made the tests smaller. |
ddudt
approved these changes
Jul 29, 2026
lkadz
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuadraticFluxwith a mixed coilset that is complex enough.compute_magnetic_fieldpull_request_target, that means they always usemastercodeplot_coilsandCoilSet.from_symmetrythat ignored the givencheck_intersectioncheck_intersectionto coil set initializerscheck_intersectionto False in many places. Only exception isFourierCurrentPotentialField.to_CoilSetas it seems a bit more important.LinearConstraintProjectionobject inperturbbenchmarks to make it faster. We internally use it in this way anyway. Also, we benchmarkLinearConstraintProjection.build()separately. Also takes it out ofsetupto prevent triggeringbuildmultiple times.