Derive microsimulation weights from household weights#497
Merged
Conversation
9523e05 to
5dc1909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438.
Refs #384.
Summary
Microsimulation.get_weights()to derive all entity weights fromhousehold_weightinstead of looking up{entity}_weightvariables.map_tothroughcalculate_dataframe()weight lookup so mapped dataframes receive weights for the dataframe entity.Verification
uv run --no-sync pytest tests/core/test_microsimulation_weights.py tests/core/test_microsimulation_person_accessor.py tests/core/test_subsample_invalidates_cache.py policyengine_core/country_template/tests/test_microsimulation.py -quv run --no-sync ruff format --check policyengine_core/simulations/microsimulation.py tests/core/test_microsimulation_weights.pyuv run --no-sync ruff check policyengine_core/simulations/microsimulation.py tests/core/test_microsimulation_weights.pyuvx --from towncrier towncrier build --draft --version 3.26.10Documentation Review
docs/python_api/simulations.mduses autodoc:members:, andget_weights()now documents that weights come fromhousehold_weight.