feat: add V3 API with state-aware callback support#29
Open
kolebynov wants to merge 9 commits into
Open
Conversation
…plugin API functionality.
…up and remove redundant build type handling.
…ce internal API helpers for streamlined invocation and listener registration.
…arity and efficiency.
…lback state handling.
…and refactor related API internals.
…estPluginAPI` for V3 support.
langfod
reviewed
May 3, 2026
| # Always build CommonLibSSE in Release mode to disable assertions and enable optimizations | ||
| set(CMAKE_BUILD_TYPE "Release") | ||
| add_definitions(-D_CRT_SECURE_NO_WARNINGS) | ||
| add_definitions(-DNDEBUG) |
Contributor
There was a problem hiding this comment.
might want to be sure no there are no commonlib asserts that can get hit
Author
There was a problem hiding this comment.
I think we should leave assertions for debug builds. They can point to potential bugs. In release mode they'll be disabled.
StarkMP
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IVPrismaUI3andInterfaceVersion::V3to expose state-aware callback variants.caller-owned
void* callbackStateback unchanged.RequestPluginAPIto return the V3 interface while preserving V1/V2 support.std::move_only_functionfor callbackstorage and dispatch.
Notes
callbackStateownership and lifetime stay with the caller.