split build_shapes rule into offshore, nuts3, country/europe rules#2169
Open
fneum wants to merge 4 commits into
Open
split build_shapes rule into offshore, nuts3, country/europe rules#2169fneum wants to merge 4 commits into
fneum wants to merge 4 commits into
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modularisation step: Split
build_shapesinto three independent rules:build_offshore_shapes(EEZ only),build_nuts3_shapes(NUTS3/ADM1 regions with GDP/population data), andbuild_shapes(country and Europe boundary aggregation).Testing yields same shapes before / after for default config.