[KNITRO] Add warm start support#3833
Conversation
… into knitro-warm-start
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3833 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 905 905
Lines 107490 107505 +15
=======================================
+ Hits 96873 96890 +17
+ Misses 10617 10615 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michaelbynum
left a comment
There was a problem hiding this comment.
This PR looks great, but it raised a broader design discussion for solver configs (see #3933 ). We are trying to figure out how to have common config options among subsets of solvers. For this PR, I think we just rename use_start to be knitro_use_warmstart so that it is clear that this option is specific to knitro. With that change, I think this will be ready to go.
blnicho
left a comment
There was a problem hiding this comment.
I found one small typo. Assuming there are no other edits to make on this, we can fix the typo right before merging without waiting for tests to run again.
Co-authored-by: Bethany Nicholson <blnicho@users.noreply.github.com>
Fixes # .
Summary/Motivation:
This PR implements the warm-start procedure for the KNITRO solver.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: