Repository navigation
Update sector tests - #44
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
|
When you say these tests fail, do you mean the tolerance is just set too high? Because that might be fair for higher-dimensional irreps |
Member
Author
|
No, it can already mismatch at the 2nd decimal. Here a quick example: |
Member
|
possibly related to failures: #61 |
This was referenced Oct 28, 2026
Merged
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lkdvos
force-pushed
the
bd/update-tests
branch
from
October 29, 2026 14:10
f307b08 to
6de3010
Compare
The sector tests no longer empty the RAM caches, so the CGCs computed there would not be written to the emptied disk cache. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lkdvos
previously approved these changes
Oct 29, 2026
The testsuite's `randsector` draws from the larger `smallset` of the sector tests, which made the fusion tree tests exceed the CI time limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lkdvos
enabled auto-merge (squash)
October 29, 2026 20:33
lkdvos
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the sector testsuite from TensorKitSectors.
SectorTestSuite.test_sectorforSU3Irrep,SU4Irrep,SU5IrrepandSU3Irrep ⊠ SU3Irrep;test/sectors.jlkeeps only the SU(N)-specific checks.*_from_fusiontensormethods of TensorKitSectors (avoidingviews);SUN_FsymbolandSUN_Rsymbolstay cached and call these.isone→isunitinSUN_CGC.Artin braid / hexagon failures
The failures for higher-dimensional irreps were a bug in TensorKitSectors'
hexagon_equation: the underbraiding usedconj(R)instead of the adjoint, which only matters for non-symmetric R-symbols such as SU(3) with fusion multiplicities. This is fixed in TensorKitSectors v0.3.12 (QuantumKitHub/TensorKitSectors.jl#119), which is now the lower compat bound.Keeping the tests within CI limits
The pentagon test scales steeply with the dimensions of the irreps, and the intermediate CGCs filled up the RAM caches (> 140 GB with the previous sets). Therefore:
smallsetis reduced to 5 SU(3) irreps of dim ≤ 11, 4 SU(4) irreps of dim ≤ 16, 3 SU(5) irreps of dim ≤ 16, and 5 products of dim ≤ 30 for SU(3) ⊠ SU(3). Each sector takes about 25–50 s and at most ~2.5 GiB.randsectordraws from the largersmallsetabove, and trees of five such irreps made these tests exceed the CI time limit.