Add option ROCM_EXAMPLES_ENABLE_HIPDNN when buildling rocm-examples to give users option to not build any hipDNN tests. hipDNN requires gcc13 to build tests for it.#457
Open
pbhandar-amd wants to merge 1 commit into
Conversation
…o give users option to not build any hipDNN tests. hipDNN requires gcc13 to build tests for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
hipDNN requires users to have gcc 13 installed on the machine. If they don't have this installed, rocm-examples will fail to compile on the
amd-stagingbranch due to the error below. Users should be able to disable hipDNN tests from building if they don't have gcc13 installed so that they can still build rocm-examples.Technical Details
Test Plan
I was able to build rocm-examples by setting -DROCM_EXAMPLES_ENABLE_HIPDNN="OFF" and DROCM_EXAMPLES_ENABLE_HIPDNN="ON"
Test Result
Was able to build and run rocm-examples.
Added/Updated documentation?
Included Visual Studio files?
Submission Checklist