Skip to content

Add option ROCM_EXAMPLES_ENABLE_HIPDNN when buildling rocm-examples to give users option to not build any hipDNN tests. hipDNN requires gcc13 to build tests for it.#457

Open
pbhandar-amd wants to merge 1 commit into
amd-stagingfrom
users/pbhandar/cmake_flag_disable_hipdnn
Open

Add option ROCM_EXAMPLES_ENABLE_HIPDNN when buildling rocm-examples to give users option to not build any hipDNN tests. hipDNN requires gcc13 to build tests for it.#457
pbhandar-amd wants to merge 1 commit into
amd-stagingfrom
users/pbhandar/cmake_flag_disable_hipdnn

Conversation

@pbhandar-amd
Copy link
Copy Markdown
Contributor

@pbhandar-amd pbhandar-amd commented May 28, 2026

Motivation

hipDNN requires users to have gcc 13 installed on the machine. If they don't have this installed, rocm-examples will fail to compile on the amd-staging branch due to the error below. Users should be able to disable hipDNN tests from building if they don't have gcc13 installed so that they can still build rocm-examples.

opt/rocm/core/include/hipdnn/test_sdk/hipdnn_test_sdk/utilities/TestTolerances.hpp: In function ‘constexpr float hipdnn_test_sdk::utilities::layernorm::getTolerance()’:
/opt/rocm/core/include/hipdnn/test_sdk/hipdnn_test_sdk/utilities/TestTolerances.hpp:344:23: error: static assertion failed: Type not supported
  344 |         static_assert(false, "Type not supported");
      |                       ^~~~~

Technical Details

Test Plan

I was able to build rocm-examples by setting -DROCM_EXAMPLES_ENABLE_HIPDNN="OFF" and DROCM_EXAMPLES_ENABLE_HIPDNN="ON"

Test Result

Was able to build and run rocm-examples.

Added/Updated documentation?

  • Yes
  • No, does not apply to this PR.

Included Visual Studio files?

  • Yes
  • No, does not apply to this PR.

Submission Checklist

…o give users option to not build any hipDNN tests. hipDNN requires gcc13 to build tests for it.
@pbhandar-amd pbhandar-amd marked this pull request as ready for review May 28, 2026 20:06
@pbhandar-amd pbhandar-amd requested a review from a team as a code owner May 28, 2026 20:06
Copy link
Copy Markdown
Collaborator

@zichguan-amd zichguan-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants