Enable hipTensor examples on Windows#458
Open
mapatel-amd wants to merge 1 commit into
Open
Conversation
hipTensor now supports Windows. Remove the Linux-only early-return guards and add install(IMPORTED_RUNTIME_ARTIFACTS hiptensor) for Windows. Also hoist ROCmPath.cmake to before find_package(hiptensor) so CMAKE_PREFIX_PATH is populated before package discovery on Windows. Follows up on #454. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
mapatel-amd
added a commit
that referenced
this pull request
May 28, 2026
hipSPARSELt supports Windows. Remove the Linux-only guards and add install(IMPORTED_RUNTIME_ARTIFACTS roc::hipsparselt) for Windows, following the same pattern applied to hipTensor in #458. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
hipTensor now supports Windows. The previous PR #454 incorrectly blocked building hipTensor examples on Windows with a Linux-only guard. This PR removes that restriction.
Technical Details
if(CMAKE_SYSTEM_NAME MATCHES "Windows") ... return() endif()guards from all 21 hipTensor CMakeLists filesinstall(IMPORTED_RUNTIME_ARTIFACTS hiptensor)for Windows in each leaf CMakeListsROCmPath.cmakeinclude to beforefind_package(hiptensor)in all leaf files, soCMAKE_PREFIX_PATHis populated before package discovery on WindowsTest Plan
Submission Checklist