Skip to content

fix[serial]: keep rx indicate callback while the port is still shared #11931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sexenteen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix[serial]: keep rx indicate callback while the port is still shared #11931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion components/drivers/serial/dev_serial.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,17 @@ static int serial_fops_close(struct dfs_file *fd)

device = (rt_device_t)fd->vnode->data;

rt_device_set_rx_indicate(device, RT_NULL);
/* close this file descriptor, but only drop the rx indication callback when
* the device is really released. The callback wakes readers (see
* serial_fops_rx_ind), so clearing it while another user still holds the
* device would make that user stop receiving input. */
rt_device_close(device);

if (device->ref_count == 0)
{
rt_device_set_rx_indicate(device, RT_NULL);
}

return 0;
}

Expand Down
Loading