bittensor-core e2es#2850
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH scrutiny: 10-day-old account with 0 public repos and 11 lifetime contributions; mitigated by repository write access, matching author/committer identity, and no Gittensor association found. Branch: bittensor-core-e2es → bittensor-core-exploration. Static analysis found no runtime changes, suspicious external dependencies, trusted AI-review instruction modifications, backdoors, or security vulnerabilities. The workflow quotes manifest-derived test names, and the only dependency addition is an existing workspace crate. FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found in the current diff. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 UNKNOWN gittensor association; very new contributor with repository write access, so the large SDK and CI surface received heightened scrutiny. The latest base merge preserves the Rust E2E migration, manifest completeness checks, SDK-specific runtime-check routing, and the TypeScript workflow self-trigger. The substantive PR description remains accurate; no spec-version bump or auto-fix applies. Static validation found no diff whitespace errors and confirmed 113 unique manifest entries; runtime confirmation was unnecessary. FindingsNo findings. ConclusionThe merge introduced no regression to the previously approved SDK client, transaction policy layer, or E2E coverage. The PR remains ready for merge. |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
1 participant
Motivation
Provide native Rust chain access and transaction coverage for
bittensor-core, and migrate the chain-facing SDK end-to-end suite from Python to a metadata-driven Rust harness. This validates reads, transaction construction, policy enforcement, submission outcomes, and higher-level SDK behavior against the repository's fast-runtime localnet image.What changed
sdk/bittensor-core/src/client.rs, including metadata refresh, pinned reads, runtime API calls, storage queries, fee estimation, signed submission, reorg-safe receipt decoding, snapshots, block streaming, and MEV-shielded submission.sdk/bittensor-core/src/transaction.rs.sdk/bittensor-core/tests/..github/workflows/check-bittensor-e2e-tests.ymlto verify manifest completeness, compile the Rust E2E binary once, build the localnet image once, and execute every manifest case independently with one retry.Behavioral impact
The Rust SDK gains native chain access and policy-aware transaction execution APIs. Chain-facing SDK coverage now runs through the Rust suite, while the Python test tree remains offline-only. Runtime and pallet behavior are unchanged.
Migration and spec version
No storage migration is required. This PR does not modify runtime or pallet behavior, and its
bittensor-core-explorationbase has no network spec-version check, so nospec_versionbump is required.Testing
CI checks the Python binding against the updated shared error surface, compiles the Rust E2E target, verifies that all 113 manifest entries exactly match the compiled tests, and runs each case against the fast-runtime localnet image. Existing SDK offline checks and runtime metadata-drift checks continue to run when their corresponding inputs change.