Repository navigation
Conversation
perfogic
requested review from
Kayden-ML,
KolbyML and
shariqnaiyer
as code owners
September 13, 2026 16:08
perfogic
marked this pull request as draft
September 13, 2026 16:18
Contributor
|
@perfogic do you plan to open this PR for me to review? |
Collaborator
Author
|
Yes, i'm going to open it now @KolbyML. Wait me for like 30 minutes |
Beacon block import required data availability to succeed immediately, so a valid block that arrived before its Fulu data column sidecars was dropped and could not be imported once the missing columns turned up. Keep such blocks pending instead: - retain executed blocks until their required data columns are available - accept blocks and columns in either order, importing as soon as availability is satisfied - persist accepted columns and backfill columns already stored in the database - retrieve missing data column sidecars by block root during sync - prune stale availability entries by finality and the configured retention window This replaces the TODO(ReamLabs#1483) rejection in `on_block`. The checker lives in the existing `ream-data-availability` crate as `checker`/`pending`, which adds a `ream-consensus-beacon` dependency there.
perfogic
force-pushed
the
feat/1483-pending-data-availability
branch
from
September 28, 2026 10:38
e28829f to
15ddf6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #1483
Beacon block import required data availability to succeed immediately. If a valid block arrived before its Fulu data column sidecars, the block was not retained and could not be imported when the missing columns arrived later.
How was it fixed?
Added a pending data availability flow that:
To-Do