Skip to content

Disable issue-1225-agent-unwrapping-EK-cert when no swtpm - #1134

Merged
kkaarreell merged 1 commit into
mainfrom
ks_disable_ek_tpm
Sep 16, 2026
Merged

kkaarreell merged 1 commit into
mainfrom
ks_disable_ek_tpm

Conversation

@kkaarreell

@kkaarreell kkaarreell commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by Sourcery

Bug Fixes:

  • Prevent the issue-1225-agent-unwrapping-EK-cert regression test from running when swtpm is unavailable.

@kkaarreell kkaarreell self-assigned this Sep 16, 2026
@sourcery-ai

sourcery-ai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The pull request adjusts the issue-1225 regression test metadata so it is skipped when swtpm is not available, avoiding invalid failures on unsupported environments.

File-Level Changes

Change Details Files
Conditionally disables the regression test when the swtpm dependency is unavailable.
  • Updates the test metadata to gate execution on swtpm availability.
  • Preserves the existing test behavior on systems that provide swtpm.
regression/issue-1225-agent-unwrapping-EK-cert/main.fmf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@kkaarreell
kkaarreell merged commit adda6af into main Sep 16, 2026
7 of 10 checks passed
@kkaarreell
kkaarreell deleted the ks_disable_ek_tpm branch September 16, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant