Skip to content

Add fmf id for test cases where is missing - #1136

Merged
Koncpa merged 1 commit into
mainfrom
pk_add_missing_fmf_uuid
Sep 16, 2026
Merged

Koncpa merged 1 commit into
mainfrom
pk_add_missing_fmf_uuid

Conversation

@Koncpa

@Koncpa Koncpa commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by Sourcery

Enhancements:

  • Add or correct FMF identifiers across functional, regression, sanity, setup, and upstream test cases.

@Koncpa Koncpa self-assigned this Sep 16, 2026
@Koncpa
Koncpa requested a review from kkaarreell September 16, 2026 08:43
@sourcery-ai

sourcery-ai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds or fixes FMF IDs in test metadata across functional, regression, sanity, setup, and upstream suites, enabling consistent test identification and selection without changing the tests’ core behavior.

File-Level Changes

Change Details Files
Add or correct FMF identifiers across test metadata so cases can be uniquely referenced and selected.
  • Populate missing id metadata in functional, regression, sanity, setup, and upstream test definitions.
  • Correct existing metadata entries where the identifier-related fields were incomplete or inconsistent.
  • Preserve the surrounding test definitions while updating metadata formatting and related lines.
functional/agent-registration-with-non-default-tpm-algorithms/main.fmf
functional/agent-resilience-and-reattestation/main.fmf
functional/attestation-mode-mismatch/main.fmf
functional/one-shot-attestation/main.fmf
functional/push-authentication-basic/main.fmf
functional/push-authentication-persistence/main.fmf
functional/push-authentication-protocol/main.fmf
functional/push-authentication-rate-limiting/main.fmf
functional/push-authentication-token-lifecycle/main.fmf
functional/verifier_registrar_unreachable/main.fmf
regression/push-tenant_cannot_access_agent_endpoint/main.fmf
sanity/manpages/main.fmf
setup/bootc_test_prepare/main.fmf
setup/disable_keylime_debug_messages/main.fmf
upstream/run_tests_for_installed_keylime/main.fmf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@kkaarreell kkaarreell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Koncpa
Koncpa merged commit 3e018e0 into main Sep 16, 2026
4 of 10 checks passed
@Koncpa
Koncpa deleted the pk_add_missing_fmf_uuid branch September 16, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants