Open
Conversation
TopHlop
reviewed
Apr 19, 2026
Comment on lines
+35
to
+38
| val minHeight by animateDpAsState( | ||
| targetValue = if (query.isNotEmpty()) 48.dp else 40.dp, | ||
| label = "", | ||
| ) |
Contributor
There was a problem hiding this comment.
А для чего это изменение высоты?
TopHlop
reviewed
Apr 19, 2026
Comment on lines
+117
to
+118
| onValueChange: () -> Unit, | ||
| onDismissRequest: () -> Unit, |
Contributor
There was a problem hiding this comment.
Тут кажется должно быть onClick, а уже при вызове кнопки передаешь нужную лямбду
TopHlop
reviewed
Apr 19, 2026
Comment on lines
+145
to
+148
| onClick = { | ||
| onValueReset() | ||
| onDismissRequest() | ||
| }, |
TopHlop
reviewed
Apr 19, 2026
Comment on lines
+131
to
+134
| when (item) { | ||
| is KonfeatureItem.Config -> "config_${item.name}" | ||
| is KonfeatureItem.Value -> "value_${item.key}" | ||
| } |
Contributor
There was a problem hiding this comment.
Лучше бы вынести это в отдельное поле внутри класса item
TopHlop
reviewed
Apr 19, 2026
| val overrideCount = state.values.count { value -> | ||
| value.configName == item.name && value.isDebugSource | ||
| } | ||
| ConfigGroupHeader( |
Contributor
There was a problem hiding this comment.
А вот тут логику никак не вынести с ui?
TopHlop
reviewed
Apr 19, 2026
Comment on lines
+350
to
+362
| when { | ||
| item.isDebugSource -> SourceLabel( | ||
| source = item.sourceName, | ||
| isDebug = true, | ||
| modifier = modifier, | ||
| ) | ||
|
|
||
| item.sourceName != "Default" -> SourceLabel( | ||
| source = item.sourceName, | ||
| isDebug = false, | ||
| modifier = modifier, | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
Тут кажется лучше
if (item.isDebugSource || item.sourceName != "Default") {
SourceLabel(
source = item.sourceName,
isDebug = item.isDebugSource,
modifier = modifier,
)
}
Contributor
There was a problem hiding this comment.
Плюс SourceLabel можно и не выносить
TopHlop
reviewed
Apr 19, 2026
| internal fun ValueItem(item: KonfeatureItem.Value, onEditClick: (String, Any, Boolean) -> Unit) { | ||
| private fun ConfigValueItem( | ||
| item: KonfeatureItem.Value, | ||
| onEditClick: (String, Any, Boolean) -> Unit, |
Contributor
There was a problem hiding this comment.
Может тут нейминг параметров еще указать, а то сходу не понятно (по всему файлу)
TopHlop
requested changes
Apr 19, 2026
Comment on lines
+350
to
+362
| when { | ||
| item.isDebugSource -> SourceLabel( | ||
| source = item.sourceName, | ||
| isDebug = true, | ||
| modifier = modifier, | ||
| ) | ||
|
|
||
| item.sourceName != "Default" -> SourceLabel( | ||
| source = item.sourceName, | ||
| isDebug = false, | ||
| modifier = modifier, | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
Плюс SourceLabel можно и не выносить
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.