fix(stats): save stats on attempt and populate stats UI#53
Open
xWalfie-SMR wants to merge 2 commits intoRhythia:indevfrom
Open
fix(stats): save stats on attempt and populate stats UI#53xWalfie-SMR wants to merge 2 commits intoRhythia:indevfrom
xWalfie-SMR wants to merge 2 commits intoRhythia:indevfrom
Conversation
this addresses issue Rhythia#43 where stats are updated in memory but not saved. StatsPanel.Update() is empty so UI still doesnt update
StatsPanel.Update() was empty so the stats panel never displayed any values even if the stats were saved
Member
|
Very nice, this fix works on my end. The only issue is that Update() isn't called after launching the game, I believe setting up a Saved signal in Stats listened to by StatsPanel would work best. |
Author
|
Sure, ill work on setting it up tomorrow, Stats already has [GlobalClass] so it should be straightforward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this addresses issue #43
Stats.Save() was never called after updating stats in LegacyRunner.Stop(), so it only stayed in memory.
StatsPanel.Update() was empty, so the stats panel never displayed any values