Repository navigation
rj_protos Cleanup #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
rj_protos Cleanup #2582
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
bb46d70
remove raw vision
sanatd33 4cfdb4b
test
sanatd33 a62701b
.
sanatd33 3d2dc18
barely works
sanatd33 2d6becf
holy i think this works
sanatd33 8c70f3a
Fix Code Style On sd/rm-logger (#2559)
github-actions[bot] 7592035
comments
sanatd33 38531f9
Merge branch 'main' into sd/rm-logger
sanatd33 78be213
Fix Code Style On sd/rm-logger (#2568)
github-actions[bot] 4bea22e
.
rishiso c350df5
Fix Code Style On sd/rm-logger (#2572)
github-actions[bot] 0845e8c
address_comments
rishiso a72ccac
.
rishiso 432916d
/
sanatd33 2e850b5
.
rishiso f77bca9
Merge branch 'main' into sd/rj_protos
rishiso 23ebb31
Fix Code Style On sd/rj_protos (#2583)
github-actions[bot] 3a20927
add submodules to build
rishiso 0519b01
/
rishiso 055e184
.
rishiso d2c3d8b
.
rishiso 774b8e9
comments
sanatd33 5308013
i had the wrong directory
sanatd33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| [submodule "external/style-configs"] | ||
| path = external/style-configs | ||
| url = https://github.com/robojackets/style-configs | ||
| [submodule "src/rj_protos/ssl-game-controller"] | ||
| path = src/rj_protos/ssl-game-controller | ||
| url = https://github.com/RoboCup-SSL/ssl-game-controller.git | ||
| [submodule "src/rj_protos/ssl-simulation-protocol"] | ||
| path = src/rj_protos/ssl-simulation-protocol | ||
| url = https://github.com/RoboCup-SSL/ssl-simulation-protocol.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SIM_PROTO_SRC is src/rj_protos/ssl-simulation-protocol/proto, set on line 12. file(READ) opens ssl_simulation_config.proto and the rest of SIM_PROTOS. If the submodule was never checked out, CMake stops with its own vague message, along the lines of file failed to open for reading plus that path. Nothing in that message says the submodule is missing or what command to run, so maybe add a check + a fatal error message indicating an easy fix for any user who encounters this:
if(NOT EXISTS ${proto_root})
message(FATAL_ERROR
"Proto submodule is missing at ${proto_root}. "
"From the repo root, run: make update-submodules")