Conversation
- Default NodeNorm taxa retrieval on so normalized nodes get Babel taxon metadata.\n- Read taxa from the top-level NodeNorm response field.\n- Keep CTD row taxon as edge context and remove the conflicting NCBITaxon node property.
Contributor
Author
|
Fixes #412 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taxafield for nodetaxon.NCBITaxonproperties and emit CTD row-level taxa as edgetaxonCURIEs.edge_merging_attributes: [taxon]to CTD-containing graph specs and downstream subgraph merge specs.Validation
uv run --with beautifulsoup4 pytest tests/test_graph_spec.py tests/test_merging.py tests/test_normalization.py tests/test_kgx_file_normalizer.py tests/test_ctd_loader.py->70 passed.stable, QC passed, 26,491 nodes, 186,376 edges.taxonproperties, 83,806 edgetaxonproperties, zeroNCBITaxon/taxonidnode or edge properties, and zero invalid taxon CURIE values.Notes
neo4j-adminis not installed locally; KGX validation completed successfully.