Skip to content

feat: enhance SequenceType to support lax object concatenation and update related tests - #1886

Draft
CaiJimmy wants to merge 1 commit into
jimmy/keep-prefix-schema-constructorfrom
jimmy/lax-object-concatenation
Draft

CaiJimmy wants to merge 1 commit into
jimmy/keep-prefix-schema-constructorfrom
jimmy/lax-object-concatenation

Conversation

@CaiJimmy

@CaiJimmy CaiJimmy commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

This gives much better static type inference when objects are not heterogeneous

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

QT3 Test Results - Parser: jsoniq

Regression baseline: run 37378363654

‼️ Regression summary: 1 previously passing test(s) now fail, error, or skip.

Suite Status Test file Test case Message
misc ERROR (unexpected-error) misc/HigherOrderFunctions.xml:hof-031 There was an error on line 4 in file:///home/runner/work/rumble/rumble/qt3tests/misc/.: string-join(local:splitter("\\s")("A nice cup of tea"), "|") ^^^^^^^^^^^^^^^^^^^^^ Code: [XPTY0004] Message: function(xs:string) as item* is not expected here. The expected type is function(xs:string) as xs:string* Metadata: file:///home/runner/work/rumble/rumble/qt3tests/misc/.:LINE:4:COLUMN:18:ENDLINE:4:ENDCOLUMN:39: This code can also be looked up in the documentation and specifications for more information.

✅ Improvement summary: 2 test(s) previously failing, errored, or skipped now pass.

Suite Test file Test case
fn fn/function-name.xml:fn-function-name-024
prod prod/FunctionDecl.xml:K2-FunctionProlog-12
Summary of passed tests for jsoniq
Test Suite Passing Failing Errors Skipped Missing features Total
app 2056 27 69 5 5 2157
array 208 0 1 0 0 209
fn 10311 268 169 387 315 11135
map 220 0 0 0 0 220
math 149 0 0 0 0 149
misc 765 34 20 52 18 871
op 4351 3 12 0 0 4366
prod 11505 328 166 208 7 12207
ser 332 11 0 0 0 343
xs 155 0 0 9 0 164
Total 30052 671 437 661 345 31821

Full analysis report: see analysis-jsoniq in artifacts.

Download detailed test results

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

QT3 Test Results - Parser: xquery

Regression baseline: run 37378363654

‼️ Regression summary: 1 previously passing test(s) now fail, error, or skip.

Suite Status Test file Test case Message
misc ERROR (unexpected-error) misc/HigherOrderFunctions.xml:hof-031 There was an error on line 4 in file:///home/runner/work/rumble/rumble/qt3tests/misc/.: string-join(local:splitter("\s")("A nice cup of tea"), '|') ^^^^^^^^^^^^^^^^^^^^ Code: [XPTY0004] Message: function(xs:string) as item* is not expected here. The expected type is function(xs:string) as xs:string* Metadata: file:///home/runner/work/rumble/rumble/qt3tests/misc/.:LINE:4:COLUMN:18:ENDLINE:4:ENDCOLUMN:38: This code can also be looked up in the documentation and specifications for more information.

✅ Improvement summary: 2 test(s) previously failing, errored, or skipped now pass.

Suite Test file Test case
fn fn/function-name.xml:fn-function-name-024
prod prod/FunctionDecl.xml:K2-FunctionProlog-12
Summary of passed tests for xquery
Test Suite Passing Failing Errors Skipped Missing features Total
app 2063 26 63 5 5 2157
array 209 0 0 0 0 209
fn 10333 247 168 387 315 11135
map 220 0 0 0 0 220
math 149 0 0 0 0 149
misc 769 30 20 52 18 871
op 4351 3 12 0 0 4366
prod 11588 279 132 208 7 12207
ser 343 0 0 0 0 343
xs 155 0 0 9 0 164
Total 30180 585 395 661 345 31821

Full analysis report: see analysis-xquery in artifacts.

Download detailed test results

@CaiJimmy
CaiJimmy force-pushed the jimmy/keep-prefix-schema-constructor branch from 29cd8ed to a0eb73c Compare October 6, 2026 21:23
@CaiJimmy
CaiJimmy force-pushed the jimmy/lax-object-concatenation branch from 73bf8fe to d100549 Compare October 6, 2026 21:23
…date related tests

This gives much better static type inference when objects are not heterogeneous
@CaiJimmy
CaiJimmy force-pushed the jimmy/keep-prefix-schema-constructor branch from a0eb73c to 5ff31d8 Compare October 6, 2026 23:39
@CaiJimmy
CaiJimmy force-pushed the jimmy/lax-object-concatenation branch from d100549 to 08bee6d Compare October 6, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant