Skip to content

Add new correctedopflash info to SR object - #195

Merged
hgreenlee merged 3 commits into
developfrom
feature/acastill_lightpropagation_updates
Oct 12, 2026
Merged

hgreenlee merged 3 commits into
developfrom
feature/acastill_lightpropagation_updates

Conversation

@asanchezcastillo

@asanchezcastillo asanchezcastillo commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Quick checklist

  • Have you run git fetch and pulled the latest changes from the branch you're basing your PR against?
  • If you're adding new classes, have you added them to classes_def.xml in the relevant directory?
  • Have you added a checksum in classes_def.xml to any and all new classes you're implementing, and rebuilt?
  • If you're updating classes, have you incremented the ClassVersion by one compared to develop in classes_def.xml?

Description

Please provide a short description of your PR.
This PR modifies the SRCorrectedOpFlashTiming object to include the photon time of flight and particle propagation time used during the correction of the op flash timing. These attributes are required for downstream correction. More information can be found here.

This PR should be merged with
SBNSoftware/sbndcode#946
SBNSoftware/sbnobj#175
SBNSoftware/sbncode#666

@asanchezcastillo
asanchezcastillo marked this pull request as ready for review July 29, 2026 14:31
@asanchezcastillo asanchezcastillo self-assigned this Jul 29, 2026
@asanchezcastillo asanchezcastillo mentioned this pull request Jul 29, 2026
4 tasks done
@PetrilloAtWork
PetrilloAtWork self-requested a review August 3, 2026 18:10

@PetrilloAtWork PetrilloAtWork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@PetrilloAtWork

Copy link
Copy Markdown
Member

Note that having setDefaults() set the same values as the construction values defeats the original purpose, which was to distinguish values that have been "forgotten" (default-constructed) from values deliberately set to a default value (setDefaults()).

However, this is not a problem introduced by this PR.

@hgreenlee
hgreenlee merged commit 4ce04b5 into develop Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants