Fix(databricks): Get correct datatypes from information_schema table#5783
Open
MisterWheatley wants to merge 1 commit intoSQLMesh:mainfrom
Open
Fix(databricks): Get correct datatypes from information_schema table#5783MisterWheatley wants to merge 1 commit intoSQLMesh:mainfrom
MisterWheatley wants to merge 1 commit intoSQLMesh:mainfrom
Conversation
…s for columns Signed-off-by: Bjarke Enkelund <47357343+MisterWheatley@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated
DatabricksEngineAdapterto querysystem.information_schema.columns(documented here) over runningDESCRIBE <table_fqn>as there are problems particularly with respect to long and nested struct columns (see issue: #5781).Test Plan
A manual test with a script was created on a sample table. Minimal script (assuming that adapter and connection is set up elsewhere and passed as argument)
Output was then manually checked over to correspond with definition from UI
NB: When running
make fast-testsomemssqlandfabrictests were observed to be failing with acannot open shared object fileerror. I assume these are unrelated to changes to Databricks adapter.In addition
tests/core/test_context.py::test_wildcardfailed with aSQLMesh project config could not be found erroragain assumed to be unrelated to this change.Additional tests were not added as the signature of the function itself didn't change.
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO