fixing dns server delete record in all roles#253
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the DNS record deletion logic across the Active Directory, FreeIPA, and Samba roles to query and delete records directly using provider-specific tools rather than relying on generic dig commands, and adds IPv6 support to the network device utility. However, the refactored deletion logic introduces several critical issues that must be addressed: multiple potential TypeError exceptions from slicing or checking None values, a logic inversion in Samba where deletion only occurs if no records are found, an AttributeError on self.zone, a typo in raise_on_error, and several Python runtime errors in FreeIPA (such as calling the non-existent trim() method and unpacking errors).
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
danlavu
force-pushed
the
ipv6
branch
4 times, most recently
from
June 18, 2026 02:34
86b2135 to
d96150a
Compare
danlavu
changed the title
thalman
reviewed
Jun 22, 2026
thalman
requested changes
Jun 22, 2026
thalman
left a comment
thalman
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good. See my question about add_device.
danlavu
force-pushed
the
ipv6
branch
7 times, most recently
from
June 25, 2026 17:31
08891e8 to
a5bc137
Compare
spoore1
requested changes
Jun 27, 2026
spoore1
left a comment
spoore1
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good and from testing it's working. I have a few nit-picks (optional mostly) and one actual question about the version pinning for pytest-mh.
danlavu
force-pushed
the
ipv6
branch
3 times, most recently
from
June 27, 2026 23:12
05fda02 to
0894b99
Compare
Contributor
Author
|
I have to redo the entire ipa logic because it was only returning one record. Looking back on this, knowing how complex it is now, I would have added more methods to find the record, get the record, etc. It may be beneficial if the look-up is faster than the dig. I think this will work in the interim. |
Contributor
Author
|
Increasing the retry/delay to a total of 120 seconds, from the run in IDMCI. |
Contributor
Author
|
working in idmci |
danlavu
force-pushed
the
ipv6
branch
3 times, most recently
from
July 15, 2026 15:00
6a51c4b to
8c066b2
Compare
added 7 commits
July 17, 2026 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dig query is insufficient because it may be cached, failing when called because it attempts to delete a record that doesn't exist in the zone.
The method logic, at a high level, goes like this: because we pass in one parameter, we need to resolve the IP address from the hostname, which may return multiple addresses. We then iterate through the zones to determine the type of record. There may be a case where the A record is deleted, but still needs to iterate through because the PTR record exists. Then we determine if it's an IPv4 or IPv6 address. Each type of record requires a different argument to delete it properly, and then there is a lot of formatting required.