Subid ldap 10.2#8957
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the system test requirements to use a personal fork of the sssd-test-framework repository and modifies test_ipa.py to conditionally configure and start SSSD with check_config=False. The review feedback correctly advises against using personal forks in the requirements file due to security and stability risks, recommending that the changes be merged upstream instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| #git+https://github.com/SSSD/sssd-test-framework | ||
| git+https://github.com/madhuriupadhye/sssd-test-framework@subid |
There was a problem hiding this comment.
Avoid referencing personal forks (such as madhuriupadhye/sssd-test-framework@subid) in the requirements file. This introduces security risks and can lead to broken builds if the fork is deleted or modified. Please merge the required changes into the official upstream repository (SSSD/sssd-test-framework) and reference the official repository instead.
alexey-tikhonov
added
no-backport
The subid LDAP configuration validator fix (PR SSSD#8403) is not yet in RHEL-10.2 builds, causing sssctl config-check to reject the subid LDAP options as unknown. Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
a1547ae to
8d60abd
Compare
3 participants
No description provided.