Repository navigation
Pinch to fill the screen, and match the Mac window from the start - #218
Closed
andrewgribben wants to merge 2 commits into
Closed
andrewgribben wants to merge 2 commits into
andrewgribben wants to merge 2 commits into
Conversation
Pinch closed brings the bar back. A two-finger double-tap can show the on-screen keyboard, off until it is turned on. Co-authored-by: Cursor <cursoragent@cursor.com>
… from the start. The Settings switch only allows the gesture. Each window starts at 1×, so resizing the iPad window resizes the Mac window without a trip through Aa. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
Thank you for this, Andrew. Since you opened it, pinch-to-zoom landed on main (#196), the hide-the-bar direction is covered by #197 and the Full Screen work under review, and I've decided today that Aa stays off by default (an explicit Off detent is coming in #181), which goes against starting every stream at 1×. So I'm closing this one rather than keep it waiting. The part I'd still like to see is the idea of the Mac window matching the iPad window from the first picture; if you want to carry that forward, an issue describing it would be welcome, and your scroll fix in #217 is on my list to merge. I appreciate the work you put in here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Made with Cursor