Repository navigation
Conversation
…ds again KeyChords.swift's paste chord reads ClipboardPolicy.pasteKey since the clipboard's Paste on the Mac, and the rig compiles KeyChords.swift without StreamProtocol's clipboard: main's rig stopped at 'cannot find ClipboardPolicy in scope'.
…y#178) A finger held 0.45 s on the picture and lifted where it was pressed (within 8 pt) right-clicks there, now at the lift; moved on past 8 pt it presses the left button where it was pressed and drags to where it lifts, so a window, a slider or a selection moves under the finger. A tap and a scroll are as before; a cancel or a three-finger stroke mid-drag lets the button up. No wire change: left down, moves, left up, as the Pencil's. TouchHold (pure, Tests/checks/touch-hold: 32 checks, 21 of 21 mutants, in CI's matrix); InputOverlay's long press feeds it. The tour's touch row says it. The touch rig's RIG_ONLY=hold runs the real overlay's holds: main right-clicked at 0.47 s and dropped the moves; this sends left down, the moves and left up.
…nts before (Saffsanity#178) The picture's hold drags since TouchHold, so a comparison against a base before it reported the overlay's 'hold 0.6 s, then move 60 and lift' as a regression.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Towards #178 (@sirasterthecat-png: "an optional direct-touch drag gesture … while preserving the current scrolling/right-click behavior"). Device only, no wire change.
A finger held on the picture for 0.45 s:
A tap still clicks and a finger that moves before the hold still scrolls. A cancel or a three-finger stroke mid-drag lets the button up and clicks nothing. The drag is the left button's down, moves and up, as the Pencil's already are, so every Sill for Mac takes it.
TouchHold(iOSClient/TouchHold.swift, pure): the rule.InputOverlayView's long press feeds it and sends what it returns.Tests/touchrig:RIG_ONLY=holdruns the real overlay's holds; a stand-in forClipboardPolicy.pasteKeyso the rig builds again on main; H7'scompare.pyholds only the trackpad's hold-and-move to the events before.Checks
Tests/checks/touch-hold(new, in CI's mutants matrix): 32 checks (20,000 random holds against a model: no button left down), 21 of 21 mutants caught.Tests/checks/tour: the new row's words;run-all.sh: all 64.StreamClientwarning.What I tried
RIG_ONLY=hold Tests/touchrig/run.sh), the realInputOverlayViewdriven by synthesized touches on an iPad Pro 11-inch (M5) simulator, iOS 27.0, against main's overlay (--rev upstream/main). A hold lifted in place right-clicked at the lift (634 ms; main 467 ms), a hold moved 60 pt sent left down at the start, ten moves and left up at the lift (main: a right click, the moves dropped), a cancel mid-drag let the button up, and a tap and a one-finger scroll were main's events exactly.Not tested