Repository navigation
Conversation
…with window tiling (Saffsanity#272) - The iPhone's key row (Saffsanity#287): a second page a swipe across the row away: esc, the four arrows and shift, where esc and shift are on the first page. The arrows are held to repeat on the Mac (Saffsanity#162), the latched modifiers carry across pages (⌥ latched, then ←: ⌥←), and VoiceOver has "Show the arrow keys" on every cap. Nothing in the layout moves (a fourth row would have cost the trackpad 52 pt and the SE its Larger Picture; a seventh cap would be 35 pt wide). DEBUG: -SillKeyPage arrows. - The Keys menu: a long press on the Keyboard button on every bar (the landscape bar, a phone's row 1, the iPad's key-row cap): Lock Screen (⌃⌘Q), Force Quit… (⌥⌘⎋), Screenshot… (⇧⌘5), Switch to the Last App (⌘⇥), and the Mac's own window tiling (Saffsanity#272: halves, Fill, Center, Return to Previous Size, macOS 15's Globe-Control shortcuts). MacShortcut, pure. - The tiling needs fn: the host now passes a device's bit 23 (the Globe key; UIKit has none, so only these shortcuts set it) as maskSecondaryFn, and says so in the window list (`fnKey`, additive, only from macOS 15: KeyStrokes.fnKey). A device offers the tiling only then: on an older host or macOS 14, fn⌃← would arrive as ⌃←, the Space on the left (the review). Checks: key-strokes 522 checks, 146 of 146 mutants (each shortcut through the host's KeyStrokes: its key down with exactly its chord, nothing held after); compatibility 154, 36 of 36; phone-portrait unchanged, 484; run-all.sh all 63; swift build -c release; the three iOS builds; harness photos of both pages at 320 and 390 pt.
…fsanity#272) One change per pull request: this one keeps the iPhone's arrow keys (Saffsanity#287), a second page of the key row a swipe away. The Keys menu, its window tiling and the host's fn bit are on the branch keys-menu-272. phone-portrait 484 checks, key-strokes 505, compatibility 151; the iOS app for the simulator builds.
addhumal
changed the title
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287. The Keys menu and its window tiling (#272) moved to #319: one change per pull request.
What it does
phone-portraitpasses unchanged, 484 checks.iOSClient/PortraitStreamScreen.swift.Next to #315
@oyyblin's #315 answers #287 too, also in one file: the row scrolls sideways (
esc tab ctrl opt cmd shift ← ↓ ↑ →), with the arrows peeking in at the edge. Here the row turns a page instead, keeping six full-width caps (56 pt on a 402 pt phone; #315's are 49 pt, 37 pt at 320 pt) but with no visible hint that a swipe turns it. Only one of the two should land; Noah's call.Checks
phone-portrait: 484, unchanged.key-strokes505 andcompatibility151, as on main.StreamClientwarning.What I tried
Problems found, and how they were fixed
Not checked