Repository navigation
Conversation
…y#279, Saffsanity#280) Noah's way back (2026-11-02): a swipe in from the edge the controls left, with a small grabber there for 2 s after hiding. - Sideways: a swipe up on the bar hides it; the picture fills the screen. - Upright, on an iPhone or an iPad: a swipe down on the rows hides the trackpad and the picture takes its room (Saffsanity#280: PhonePortraitLayout's trackpadHidden, the halves' own split), the viewport following, so the Mac fits the window to the taller picture; a second swipe hides the rest. A swipe up on the rows brings the trackpad back. - Everything hidden: a swipe in from the top (sideways) or the bottom (upright) brings it all back, ahead of iOS's own edge swipe (defersSystemGestures); the grabber is a button; VoiceOver has "Show Sill's controls" on the picture, "Hide Sill's controls" and "Show the trackpad" on the rows. Turned sideways with only the trackpad hidden, the bar shows. Not while the drawer, Settings or Aa's ruler is open. - HiddenControls (pure, in PhonePortraitLayout.swift): the steps, the way back, and what counts as a swipe (40 pt, twice as far up or down as across: a thumbnail strip's scroll is no swipe). - DEBUG: -SillHideControls trackpad|all. Checks: phone-portrait 491 (7 new: the steps, the swipe, 273 phone sizes with the trackpad hidden) and 79 of 79 mutants (6 new; M3 repointed; an equivalent one showed a dead guard, removed); run-all.sh all passed; the three iOS builds; harness photos on a private iPad Pro 13" simulator (iOS 27.0, deleted after): a 390x844 phone upright with and without the trackpad, the iPad upright without it, sideways with everything hidden.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #279 and #280. Sill's controls can now be swiped away so the picture gets the screen. Upright, the picture grows into the room they leave.
How it works
HiddenControls: pure, in PhonePortraitLayout.swift. DEBUG:-SillHideControls trackpad|all.Problems found, and how they were fixed
accessibilityActions, with "Show the trackpad" only when it's hidden.Checks
phone-portrait: 491 checks (7 new: the steps, the swipe rule, 273 phone sizes with the trackpad hidden: the picture takes all its room, the rows unchanged, nothing off the screen). 79 of 79 mutants (6 new).run-all.sh: all passed.Not checked: the swipes and the edge swipe with a real finger (no touch rig was run), the grabber's 2 s, the Duo's halves, VoiceOver.
@Saffsanity: on the iPhone upright, swipe down on the buttons twice, then swipe up from the bottom edge. Sideways, swipe up on the bar, then down from the top.