Repository navigation
iOS: native autocorrection and a visible landscape typing editor - #306
Open
fJavierLasso wants to merge 2 commits into
Open
fJavierLasso wants to merge 2 commits into
fJavierLasso wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the native keyboard’s autocorrection, spelling suggestions and inline predictions. With the software keyboard open in landscape, a native text editor above it shows and edits the current typing context.
The editor relays replacements through
TextComposition, so a correction updates the Mac by the required backspaces and replacement text. Content before a submitted Return or Tab remains protected. Moving the Mac’s caret commits the draft and clears the local context. Keyboard ownership follows the existing proxy through editor focus, dismissal and hardware-keyboard transitions. Typing consumes latched modifiers and hides the local pointer as the existing keyboard path does.Validation
Tests/checks/run-all.shpassed, including 194 text-composition checks.Real-keyboard correction choices depend on the device’s keyboard language and settings. The visible editor contains the text typed in the current caret context.