Repository navigation
Conversation
…PN may be off (Saffsanity#309) 'Tailscale looks off on this iPhone' sent people to fix the iPhone when Tailscale was off on the Mac: the device can't tell which end is off. Now 'Tailscale looks off on this iPhone or on ‹Mac›. Turn it on on both, then tap ‹Mac›.' ('Your VPN' with no service name), and a .ts.net name not found asks 'Is Tailscale on, here and on ‹Mac›?'. RemoteCopy moves unchanged from StreamClient+Remote.swift to RemoteDialPolicy.swift, which remote-rules compiles, so its words are checked: 179 checks (7 new), 90 of 90 mutants (2 new); run-all.sh all 63; the three iOS builds. The plan's table and DEVELOPMENT.md quote the new words.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309 (@grub-basket's finding and wording).
What it does
When a dial through Tailscale (or another VPN) fails in a way the device can't pin on one end, the status line now names both ends instead of only this device:
.vpnOff: "Tailscale looks off on this iPhone or on ‹Mac›. Turn it on on both, then tap ‹Mac›." ("Your VPN" when the address has no service name). Was "Tailscale looks off on this iPhone. Turn it on, then tap ‹Mac›.".nameNotFoundfor a.ts.netname: "This iPhone can’t look up ‹name›. Is Tailscale on, here and on ‹Mac›?" Was "… Is Tailscale on?". Other names are unchanged..noAnsweris unchanged: it already names the Mac ("…or Tailscale may be off on the Mac").RemoteCopy(the status line's words) moves unchanged fromStreamClient+Remote.swiftto the end ofRemoteDialPolicy.swift, whichTests/checks/remote-rulesalready compiles, so the words are checked for the first time.RemoteDialPolicy.classifyis untouched. No wire change; device only.Docs: docs/remote-access-plan.md's status-line table and DEVELOPMENT.md's troubleshooting line quote the new words.
Checks
Tests/checks/remote-rules: 179 checks (7 new: both VPN kinds, both devices, no candidate, the lookup, and the two unchanged cases), 90 of 90 mutants (2 new: each new sentence back to this device alone).run-all.sh: all 63.What I tried
Not checked
usedTunnel == falseon a VPN address, which does point at this device's own tunnel) should keep this device's words. I gave it both ends too, as the reporter asked, since a word about the Mac costs nothing there.