Skip to content

fix: nestjs #83

Open
ismoiliy98 wants to merge 8 commits intoSaltyAom:mainfrom
ismoiliy98:fix-nestjs
Open

fix: nestjs #83
ismoiliy98 wants to merge 8 commits intoSaltyAom:mainfrom
ismoiliy98:fix-nestjs

Conversation

@ismoiliy98
Copy link
Copy Markdown
Contributor

  • Fixes nest js implementation
  • Adds fastify adapter implementation for nest js
  • Fixes bench.ts script where the header is set incorrectly in the commands array.
    Details When you split the command string by spaces (command.split(' ')), a shell does not interpret the single quotes. Instead, they are passed literally as part of the argument. Bombardier receives the header as 'content-type:application/json' (including the quotes), which is not a valid Content-Type header. This caused a problem with Fastify when I ran the benchmark on it. Fastify defaults to the application/octet-stream content type, throwing errors because there are no handlers for the application/octet-stream media type set by default in the nest js fastify adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant