Repository navigation
Overhaul the CI Tests - #325
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This update overhauls the old CI that tested installs that no user ever did, and fixes the issue where of its workflows installed the released package from PyPI instead of the code in the repo. The new CI follows the documented installation guides and test the commits in the PR. This also adds a new pre-release check that builds the wheel and sdist and installs them before a release goes live.
What changed
New workflows
tests.yml, jobpypi-installmain/develop/dev/**, PRs, manualpip install ., thenconda install gdalon top.pip checkmust pass and pyTMD must be 3 or newer.tests.yml, jobconda-forge-installmain/develop/dev/**, PRs, manualpip install --no-deps .. Differences betweenpyproject.tomland the feedstock are show as a warning, not a failure.dev-install.ymlmain/develop/dev/**, PRs, manualpip install -e ".[test]"into an env holding only python and gdal. Also checks thatcoastsegimports from the checkout and not from site-packages.release_env_matrix.yml("Pre-release: build & install matrix")Publish_package_to_pypi.yml), manualtwine check, and checks that the runtime data files (bounding-box CSVs,tide_regions_map.geojson) are in the wheel. Installs the built files, then runs an import check and pytest from outside the checkout.New script:
.github/scripts/check_release_ready.pyIt runs all five checks below:
path/git/urloverrides in[tool.pixi.pypi-dependencies]pixi.lockpkg @ git+...direct references in[project.dependencies], which PyPI rejects after the tag is already pushedrequires-python, the trove classifiers, and the CI matrix list the same Python versionsproject.versionRemoved
pip_install_e.yml, replaced bydev-install.ymltest_coastseg.yml. It ranpip install coastseg --userfrom PyPI, so it tested the released package and not the code in the PR. It also used a python 3.10 and a tensorflow environment withactions/checkout@v3andsetup-miniconda@v2.ci/envs/{38,39,310,311,312,313}-coastseg.yaml. These environment files are no longer needed with the new CI tests,Other changes
test_coastseg_with_pixi.yml: addedworkflow_dispatchso it can be run by hand before a release.README.md: the singlepip_install_e.ymlbadge is replaced by badges fortests.ymlandrelease_env_matrix.yml.