Skip to content

Split Smoother Matrix Construction into Separate COO and Tridiagonal Sections#246

Open
julianlitz wants to merge 17 commits intomainfrom
litz_mjoelnir_2
Open

Split Smoother Matrix Construction into Separate COO and Tridiagonal Sections#246
julianlitz wants to merge 17 commits intomainfrom
litz_mjoelnir_2

Conversation

@julianlitz
Copy link
Copy Markdown
Collaborator

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@julianlitz julianlitz changed the title Test Split Smoother Matrix Construction into Separate COO and Tridiagonal Sections May 4, 2026
@julianlitz
Copy link
Copy Markdown
Collaborator Author

julianlitz commented May 4, 2026

@EmilyBourne I removed the Residual and DirectSolver changes.
I think it cant really be simplified further into multiple PRs...
You can mostly ignore the new parallelization approach since

  1. We will do it differently with Kokkos nevertheless
  2. I can assure you this new way is a lot better and works the same

Note that the Smoother Give is very well tested against the Take counter part.
If a single matrix entry is not the same, the tests will fails immediately.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (85dfe79) to head (f7acf51).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   90.10%   90.02%   -0.08%     
==========================================
  Files          80       79       -1     
  Lines        8854     8706     -148     
==========================================
- Hits         7978     7838     -140     
+ Misses        876      868       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmilyBourne
Copy link
Copy Markdown
Collaborator

@julianlitz I merged #247 . Can you fix the merge conflicts that this has created

@julianlitz
Copy link
Copy Markdown
Collaborator Author

🫠 Oki

@julianlitz
Copy link
Copy Markdown
Collaborator Author

@EmilyBourne Conflicts resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants