Split Smoother Matrix Construction into Separate COO and Tridiagonal Sections#246
Open
julianlitz wants to merge 17 commits intomainfrom
Open
Split Smoother Matrix Construction into Separate COO and Tridiagonal Sections#246julianlitz wants to merge 17 commits intomainfrom
julianlitz wants to merge 17 commits intomainfrom
Conversation
Collaborator
Author
|
@EmilyBourne I removed the Residual and DirectSolver changes.
Note that the Smoother Give is very well tested against the Take counter part. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 90.10% 90.02% -0.08%
==========================================
Files 80 79 -1
Lines 8854 8706 -148
==========================================
- Hits 7978 7838 -140
+ Misses 876 868 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@julianlitz I merged #247 . Can you fix the merge conflicts that this has created |
Collaborator
Author
|
🫠 Oki |
Collaborator
Author
|
@EmilyBourne Conflicts resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):