Repository navigation
e2e operate: report gateway exceptions as a failed operation - #82
Merged
Merged
Conversation
operate.php caught only QuickpayException (the API refusing a request), so a Payum-side exception surfaced as an uncaught fatal with a stack trace. Seen live during the #73 check: OperationRejectedException from #72 — Quickpay processed the capture and the acquirer declined it. It now reports those the same way, naming the exception class: capture ... FAILED: OperationRejectedException: Quickpay declined the capture of payment … Refs #71.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #82 +/- ##
=========================================
Coverage 98.40% 98.40%
Complexity 199 199
=========================================
Files 19 19
Lines 501 501
=========================================
Hits 493 493
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness only (
examples/e2e/operate.php, outside the phpstan/ecs paths — checked withphp -l).operate.phpcaught onlyQuickpayException(the API refusing a request), so a Payum-side exception surfaced as an uncaught fatal with a stack trace. Seen live during the #73 check:OperationRejectedExceptionfrom #72 — Quickpay processed the capture up front and the acquirer declined it. It now reports those like an API failure, naming the class:Also covers
OperationPendingException(#80), "nothing left to refund" and a missingquickpayPaymentId.