Repository navigation
Pre-RC polish: ship the README in the dist, drop always-on ext requirements, un-stale the docs - #85
Merged
Merged
Conversation
…ements, un-stale the docs Found in a final pass over 2.x before the release candidate: - .gitattributes export-ignored README.md, so a dist install from Packagist shipped without the package's documentation while docs/UPGRADE-2.0.md did ship — the exact gap the SDK closed on its side in 1.1. The README ships now; the dev tooling stays ignored. - ext-hash and ext-json date from when Api computed the callback HMAC and decoded JSON itself; since the SDK took both over, src/ uses neither — and both extensions are always-enabled on PHP >= 8.0 anyway, so the requirements were pure noise. ext-ctype and ext-filter (genuinely used, genuinely disableable) stay. - docs/UPGRADE-2.0.md still said state logic lives in the Operations helper (deleted with SDK 1.2); the balance-writers lists in README, UPGRADE and CLAUDE.md predated the in-flight guard making Cancel and every Refund fetch too — every action that touches the payment writes balance now, and the docs say so. - One test row: a newer pending operation of a type the in-flight guard ignores (an authorize made outside the gateway) must not mask a pending money operation earlier in the list — kills the one semantically meaningful escaped mutant in assertNoneInFlight(). Refs #71.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #85 +/- ##
=========================================
Coverage 98.53% 98.53%
Complexity 203 203
=========================================
Files 19 19
Lines 545 545
=========================================
Hits 537 537
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings from a final review pass over
2.xbefore drafting the RC — all small and mechanical:.gitattributesexport-ignoredREADME.md, so a dist install from Packagist shipped without the package's documentation (whiledocs/UPGRADE-2.0.mddid ship) — the exact gap the SDK closed on its side in 1.1 (Dependabot can't resolve your PHP dependency files #21 there). The README ships now; the dev tooling stays ignored.ext-hash/ext-jsondropped fromrequire: they date from whenApicomputed the callback HMAC and decoded JSON itself. Since the SDK took both over,src/uses neither — and both extensions are always-enabled on PHP ≥ 8.0 anyway, so they were pure noise.ext-ctype/ext-filter(genuinely used inDetails/the factory, genuinely disableable) stay.docs/UPGRADE-2.0.mdstill said state logic lives in theOperationshelper (deleted with SDK 1.2); the balance-writers lists in README/UPGRADE/CLAUDE.md predated Refuse to queue a capture/refund/cancel while one is still in flight #80 makingCanceland everyRefundfetch — every action that touches the payment writesbalancenow, and the docs say so.OperationPendingException::assertNoneInFlight(): a newer pending operation of a type the guard ignores (an authorize made outside the gateway) must not mask a pending money operation earlier in the list — kills the one semantically meaningful escaped mutant there.Full gate green (368 tests); analyser,
validate --strict,normalizeclean;composer auditno advisories.The review verdict itself is in the conversation: no blocking findings — with this in,
2.xis RC-ready from my side.