Repository navigation
Conversation
The tree builder chain was never terminated: cookie_name is missing its ->end() and so is the surrounding ->children(). It produces the right tree today because nodes are attached to their parent when they are created rather than when end() is called, so nothing was broken. It is a trap for the next edit though. Appending another node to the chain would attach it to the scalar node instead of to children(), which fails in a way that does not obviously point back here. config:dump-reference output is unchanged. Claude-Session: https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tree builder chain in
Configurationis never terminated —cookie_nameis missing its->end(), and so is the surrounding->children().It builds the correct tree today, because
NodeBuilderattaches a node to its parent when the node is created, not whenend()is called. So this is a latent trap rather than a live bug: append one more node to the chain and it gets attached to the scalar node instead of tochildren(), failing in a way that does not obviously point back at the missingend().Verified as a no-op by diffing
bin/console config:dump-reference setono_sylius_toggle_vatbefore and after — byte-identical:Addresses a nitpick from #5.
https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a