Repository navigation
Conversation
The @var annotation on the processed configuration still declares decorate_price_helper, an option that no longer exists in Configuration. The shape describes what processConfiguration() actually returns, so an extra key in it is a false promise to both readers and Psalm. Claude-Session: https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@varannotation on the processed configuration inSetonoSyliusToggleVatExtensionstill declaresdecorate_price_helper: bool. That option no longer exists inConfiguration— it went away when the plugin stopped decoratingPriceHelper.The shape is meant to describe what
processConfiguration()actually returns, so a key that can never be present is a false promise to both the next reader and to Psalm, which will happily type-check an access that would be undefined at runtime.decorate_price_helpernow appears nowhere insrc/,tests/or the README.Addresses a nitpick from #5.
https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a