Repository navigation
Conversation
Installing the plugin makes every rendered price depend on a cookie. A shop that already sits behind Varnish or a CDN will keep serving whichever VAT variant was cached first, to everyone, and the mismatch shows up as wrong prices rather than as a missing toggle. Claude-Session: https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing this plugin changes the caching characteristics of every page that renders a price: the output now depends on a cookie.
A shop already sitting behind Varnish, a CDN, or Symfony's HTTP cache will keep serving whichever VAT variant happened to be cached first, to everyone. It is worth calling out explicitly because of how it presents — not as "the toggle is broken", but as wrong prices, which is the kind of bug that gets reported by a customer rather than caught in testing.
Adds a short Caching section naming the cookie and pointing at varying on it or excluding price pages.
No code changes.
Addresses the third security/ops item in #5.
https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a