Repository navigation
Add notes to wishlist items, plus update-flow fixes - #8
Merged
Merged
Conversation
The bundle had been left on the beta constraint (^1.0@beta); 1.2 is the newest stable release.
Each wishlist item gets an optional free-text note (nullable text column) that the owner can edit via a textarea in the existing wishlist form and that recipients of a shared wishlist see as read-only text. Also top-aligns the wishlist item rows so the now taller, multi-line note cells line up cleanly with the other columns.
Updating a wishlist re-rendered the page in place: no feedback was shown and a browser refresh re-submitted the form. Add a success flash and redirect back to the wishlist (POST/Redirect/GET).
The notes claimed there were no test classes and that infection requires 100% MSI; both are stale. There is now a tests/Unit suite and the thresholds are minMsi 25 / minCoveredMsi 95.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
============================================
+ Coverage 36.49% 36.60% +0.10%
- Complexity 162 165 +3
============================================
Files 36 36
Lines 485 500 +15
============================================
+ Hits 177 183 +6
- Misses 308 317 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in here
This branch bundles the wishlist-item notes feature plus a couple of UX fixes and chores discovered along the way. Each is a separate commit for easy review.
Add notes to wishlist items (closes #2)
Each wishlist item gets an optional free-text note (nullable
textcolumn). The owner edits it via a textarea in the existing wishlist form; recipients of a shared wishlist see it as read-only text. Wishlist item rows are now top-aligned so the taller, multi-line note cells line up with the other columns.WishlistItem/WishlistItemInterface:noteproperty + accessors<field name="note" type="text" nullable="true"/>WishlistItemType:notetextarea (saved by the existing PATCH form — no new controller/route/JS)messages.{en,da,no}.yaml:notelabelshow.html.twig: note column +vertical-align: topFlash a confirmation and redirect after updating a wishlist
Updating a wishlist re-rendered the page in place — no feedback, and a browser refresh re-submitted the form. Now it adds a success flash and redirects back to the wishlist (POST/Redirect/GET).
ShowWishlistAction: success flash + redirect;routerinjected viacontroller.xmlflashes.{en,da,no}.yaml:wishlist_updatedmessageShowWishlistActionTest: updated + asserts the redirect target and flashChores
setono/client-bundleto^1.2(was left on^1.0@beta).CLAUDE.md(there is now atests/Unitsuite; infection thresholds areminMsi 25/minCoveredMsi 95, not 100% MSI).Verification
composer analyse(PHPStan max),composer check-style(ECS),rector --dry-run— cleancomposer phpunit— 59 tests / 97 assertions passvendor/bin/infection— Covered Code MSI 100%, MSI 34% (both over threshold)lint:twig,lint:yaml,lint:containerclean;doctrine:schema:validatemapping correctNot included
The "Add wishlist to cart fails when an item has no variant" UX problem (#7) is intentionally out of scope here.