Skip to content

Tighten preview store client test types#7890

Open
alfonso-noriega wants to merge 1 commit into
mainfrom
maintenance/preview-storage-test-types
Open

Tighten preview store client test types#7890
alfonso-noriega wants to merge 1 commit into
mainfrom
maintenance/preview-storage-test-types

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

No issue.

The preview-store client tests used an as any cast in the in-memory storage helper even though the helper only stores a cliInstanceId string.

WHAT is this pull request doing?

Add a narrow test storage schema and type the in-memory storage helper around the cliInstanceId key.

The helper now avoids the as any cast and more closely matches the LocalStorage methods used by the production code.

How to test your changes?

  • pnpm nx run store:lint --skip-nx-cache
  • pnpm --dir packages/store vitest run src/cli/services/store/create/preview/client.test.ts

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Not user-facing; no changeset needed.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 22, 2026
@alfonso-noriega alfonso-noriega marked this pull request as ready for review June 22, 2026 09:26
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner June 22, 2026 09:26
@alfonso-noriega alfonso-noriega force-pushed the maintenance/preview-storage-test-types branch from 8aaa75c to 8b6928c Compare June 22, 2026 09:32
@alfonso-noriega alfonso-noriega force-pushed the maintenance/preview-storage-test-types branch from 8b6928c to 958d923 Compare July 9, 2026 12:56
@alfonso-noriega alfonso-noriega changed the title Tighten preview store test storage types Tighten preview store client test types Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants