Tighten preview store client test types#7890
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
8aaa75c to
8b6928c
Compare
8b6928c to
958d923
Compare
isaacroldan
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
No issue.
The preview-store client tests used an
as anycast in the in-memory storage helper even though the helper only stores acliInstanceIdstring.WHAT is this pull request doing?
Add a narrow test storage schema and type the in-memory storage helper around the
cliInstanceIdkey.The helper now avoids the
as anycast and more closely matches theLocalStoragemethods used by the production code.How to test your changes?
pnpm nx run store:lint --skip-nx-cachepnpm --dir packages/store vitest run src/cli/services/store/create/preview/client.test.tsPost-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addNot user-facing; no changeset needed.