Skip to content

Include run token in E2E dev store names#7977

Merged
gonzaloriestra merged 1 commit into
mainfrom
07-01-e2e_store_run_token
Jul 3, 2026
Merged

Include run token in E2E dev store names#7977
gonzaloriestra merged 1 commit into
mainfrom
07-01-e2e_store_run_token

Conversation

@alfonso-noriega

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

E2E app names include the GitHub Actions run token, which lets the post-run cleanup job target only resources from the current run. Dev store names only used the worker index and timestamp, so a current-run store cleanup job could not safely target stores without risking other active runs.

WHAT is this pull request doing?

Adds a shared E2E run segment helper and includes that segment in generated dev store names. Store names now include the same r<run-id-base36>a<attempt> segment as E2E app names.

How to test your changes?

  • cd packages/e2e && pnpm tsc --noEmit
  • cd packages/e2e && pnpm eslint "setup/**/*.ts" "helpers/**/*.ts" "tests/**/*.ts" "*.ts"
  • node bin/run-knip-ci.js

Note: ESLint completed successfully with existing Nx project graph cache warnings for @nx/enforce-module-boundaries.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is not user-facing; no changeset is needed.

Assisted-By: devx/56dcddb4-0bb1-4e96-b794-1bb2fda2cba1
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner July 1, 2026 14:20
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 1, 2026
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jul 3, 2026
Merged via the queue into main with commit 60bcf48 Jul 3, 2026
53 of 54 checks passed
@gonzaloriestra gonzaloriestra deleted the 07-01-e2e_store_run_token branch July 3, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants